moose
moose copied to clipboard
idaholab
Build a mesh generator which creates an overlaying mesh over the given mesh
This PR #23513 built a new mesh generator that can generate an overlay mesh with the given mesh block.
Reason
This OverlayMeshGenerator will help meshing the gap between different mesh blocks so that we can do ray tracing in the gap region with relatively low cost. This capability is a part of the efforts to model radiative heat transfer in the gap regions between mesh blocks.
Design
The overlay mesh uses DistributedRectilinearMeshGenerator(DistributedRectilinearMeshGenerator.md) as sub-generator. The generate() method is overloaded and use MeshTools::Modification::scale and MeshTools::Modification::translate to overlay the new mesh with the input mesh. The input parameters for DistributedRectilinearMeshGenerator are all available for OverlayMeshGenerator. The required input parameters of OverlayMeshGenerator are dim (the dimension of the domain) and input (the base mesh we want to overlay).
Impact
This OverlayMeshGenerator will help meshing the gap between mesh blocks. This capability is a part of the efforts to enable ray tracing and radiative heat transfer in the gap region.
Job Documentation on 53edc62 wanted to post the following:
View the site here
This comment will be updated on new commits.
@loganharbour Could you add this PR to your review list as well? Big Thanks! :)
Job Coverage on 53edc62 wanted to post the following:
Framework coverage
| 796cb8 | #23513 53edc6 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.24% | 85.24% | +0.00% | 88.89% | |
| Hits | 99138 | 99172 | +34 | 32 | |
| Misses | 17166 | 17168 | +2 | 4 | |
Modules coverage
Coverage did not change
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_transfer -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_properties -
stochastic_tools -
tensor_mechanics -
thermal_hydraulics -
xfem
Warnings
-
frameworknew line coverage rate 88.89% is less than the suggested 90.0%
This comment will be updated on new commits.
I m excited for this. Meshing by overlaying rectilinear meshes and just cutting parts out is not as difficult conceptually to do as just meshing arbitrary volumes lining up with boundaries exactly and it s a viable approach for many problems.
awesome work!
It s not quite the generator I thought though. Would it be possible to meet with the team driving this to pitch an extension?
Sure, just let me know what time works for you.
Can do Monday 11am MST for example. This week I dont know with Derek in town
Can do Monday 11am MST for example. This week I dont know with Derek in town
Works for me. Derek is not this week. I'll ask @friedmud and @loganharbour about their schedule. This mesh generator is mainly designed for radiative heat transfer. The main goal is to calculate the view factor in the gap region(no mesh area). My next step is to build communication between main mesh edges and the overlay mesh.
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Which of the two is preferred / earlier?
#24098 is the latest one. All the changes in this PR is brought to #24098 in order to develop other capabilities.
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
I have quibbles about wording and I think some of those header inclusions are atavisms from other files (or older versions?) but I'm not seeing any serious issues.
Thanks Roy!