moose icon indicating copy to clipboard operation
moose copied to clipboard

Addfreundlich

Open ke7kto opened this issue 2 years ago • 3 comments

Closes #22382

Not sure which module would be most appropriate to add this functionality to.

ke7kto avatar Oct 12 '22 21:10 ke7kto

Yes. This is for mass transfer. I will rebase, sorry about that. I'm not sure how to make a test for an interfacekernel. How does that work?

ke7kto avatar Oct 12 '22 21:10 ke7kto

Job Documentation on 8d1875b wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar Oct 12 '22 23:10 moosebuild

Job Coverage on 8d1875b wanted to post the following:

Framework coverage

c62e4c #22383 8d1875
Total Total +/- New
Rate 84.30% 84.26% -0.04% 24.59%
Hits 80164 80175 +11 15
Misses 14927 14977 +50 46

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 24.59% is less than the suggested 90.0%

This comment will be updated on new commits.

moosebuild avatar Oct 13 '22 01:10 moosebuild

Yes. This is for mass transfer. I will rebase, sorry about that. I'm not sure how to make a test for an interfacekernel. How does that work?

Use it in an input file that gets run by the test harness. I might suggest weighting a week or two for us to submit the pull request that creates the scalar transport module (we are waiting on final export control approval), because I think this object fits the best in that module

lindsayad avatar Oct 13 '22 20:10 lindsayad

https://github.com/idaholab/moose/pull/22392 will introduce the scalar_transport module which would be a good place for your code

lindsayad avatar Oct 14 '22 15:10 lindsayad