moose
moose copied to clipboard
idaholab
Added functionality for BoundaryNames in SideSetsFromBoundingBoxGenerator
Job Documentation on df97728 wanted to post the following:
View the site here
This comment will be updated on new commits.
These will fail due to unedited mesh_modifier tests and should be reran once the PR deleting them has been dealt with.
Job Coverage on df97728 wanted to post the following:
Framework coverage
| ea3de6 | #22293 df9772 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 84.29% | 84.28% | -0.01% | 63.16% | |
| Hits | 80175 | 80180 | +5 | 24 | |
| Misses | 14940 | 14957 | +17 | 14 | |
Modules coverage
Coverage did not change
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_conduction -
level_set -
misc -
navier_stokes -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
solid_properties -
stochastic_tools -
tensor_mechanics -
thermal_hydraulics -
xfem
Warnings
-
frameworknew line coverage rate 63.16% is less than the suggested 90.0%
This comment will be updated on new commits.
Job Precheck on e22746c wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/docs/PRs/22293/clang_format/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format 1cd91e61ff5b6c9d14ef83a94b6ae512e8a3f546
Let's fix the commit history. We dont really want to add then remove a test in the next commit. We dont really want "address review" commit messages either. Each commit should say what it contains
I d squash commit 2 with 5 and 4 with 6 and 7.
In general try to use git commit --fixup as often as possible instead of adding brand new commits
