moose icon indicating copy to clipboard operation
moose copied to clipboard

Parallel active learning in Monte Carlo simulations with Gaussian Process

Open somu15 opened this issue 2 years ago • 5 comments

To do :

  • [ ] Error checking and tests
  • [x] Enum options for active learning acquisition functions
  • [ ] Documentation

closes #22280

somu15 avatar Oct 03 '22 04:10 somu15

Please do not review this yet. I need to make a few more additions/changes. (wondering whether I can add labels...)

somu15 avatar Oct 03 '22 04:10 somu15

You cant add labels sorry. Which label were you thinking of adding?

GiudGiud avatar Oct 03 '22 19:10 GiudGiud

You cant add labels sorry. Which label were you thinking of adding?

Maybe "do not review" or "do not merge"? But if I cannot remove them, I'd prefer not having them.

somu15 avatar Oct 03 '22 20:10 somu15

You would not be able to remove them but also we would do it for you and doubt it would become an issue

You can also turn your PR to a draft if you want

GiudGiud avatar Oct 03 '22 20:10 GiudGiud

You would not be able to remove them but also we would do it for you and doubt it would become an issue

You can also turn your PR to a draft if you want

Draft is a great idea!

somu15 avatar Oct 03 '22 20:10 somu15

Job Documentation on 5f25b5b wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar Oct 15 '22 21:10 moosebuild

@zachmprince @grmnptr This is ready for review. I am only fixing some minor doc issues.

somu15 avatar Oct 18 '22 22:10 somu15

Job Precheck on d4faaf6 wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/22282/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 88ca6d4e7b9e91717f598187ebe561e1e18f9581

moosebuild avatar Oct 27 '22 16:10 moosebuild

Job Coverage on 5f25b5b wanted to post the following:

Framework coverage

e40a32 #22282 5f25b5
Total Total +/- New
Rate 84.62% 84.62% -0.00% -
Hits 81970 81966 -4 0
Misses 14897 14901 +4 0

Diff coverage report

Full coverage report

Modules coverage

Stochastic tools

e40a32 #22282 5f25b5
Total Total +/- New
Rate 91.17% 91.29% +0.11% 95.11%
Hits 6073 6243 +170 175
Misses 588 596 +8 9

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

moosebuild avatar Oct 30 '22 05:10 moosebuild

Thanks, @grmnptr for the comments.

somu15 avatar Oct 31 '22 21:10 somu15

Any idea what this means? Screen Shot 2022-11-22 at 9 49 24 PM

somu15 avatar Nov 23 '22 04:11 somu15

Probably just a network error causing the test harness to crash after. It seems invalidating it fixed it

GiudGiud avatar Nov 23 '22 11:11 GiudGiud

Thanks!

somu15 avatar Nov 23 '22 15:11 somu15

Thanks, @zachmprince for the comments. For those comments, I had issues or questions, I will directly responded to the specific comment.

somu15 avatar Dec 07 '22 20:12 somu15

Job Precheck on f6f08ba wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/22282/clang_format/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format af38e9f0b6976df8d0a90b1c6b339bef1dbc9b00

moosebuild avatar Dec 07 '22 20:12 moosebuild

Job Documentation on 9f65c8f : invalidated by @grmnptr

moosebuild avatar Jan 17 '23 14:01 moosebuild

@zachmprince Can you merge this? Do I have to do a rebase and push again?

somu15 avatar Jan 23 '23 15:01 somu15