moose
moose copied to clipboard
idaholab
Transfinite mesh generator
It can generate meshes within closed domains. Needs a few test examples, address all circular arc cases, add parsed parameterizations and discrete edge capabilities.
The underlying algorithm follows https://en.wikipedia.org/wiki/Transfinite_interpolation
Extensions for automating circular arcs and other parameterizations have been developed for particular meshes of interest.
closes #21903
Job Documentation on 1c4ca24 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage on 1c4ca24 wanted to post the following:
Framework coverage
| 1542ca | #21904 1c4ca2 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 85.08% | 85.11% | +0.04% | 99.13% | |
| Hits | 86330 | 86561 | +231 | 227 | |
| Misses | 15144 | 15142 | -2 | 2 | |
Modules coverage
Coverage did not change
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_conduction -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_properties -
stochastic_tools -
tensor_mechanics -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
Job Precheck on 71242dd wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/docs/PRs/21904/clang_format/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format f9a393f53b4d7088fc66ea23947b446be99816b1
I'd scale down the object name, for example by adding '2D' or XY as appropriate so that the next iteration that provides more capability, if ever, does not look more specific than this one
@GiudGiud Not sure which object you are referring to, the main TransfiniteMeshGenerator ->TransfiniteMeshGenerator2D?
This is a good opportunity to get comfortable with adding stuff to the
large_mediasubmodule - all of the images should be there and be removed from history
You spotted it right away, I wanted to do large_media but got caught up in the submodule and given the small size I hoped I can get away without. :)
Transfinite2DMeshGenerator ? I m referring to the object name, the one in the input file
What do you mean in the input file? Are you saying that type = TransfiniteMeshGenerator doesn't have to correspond name-wise to registerMooseObject("MooseApp", TransfiniteMeshGenerator);, that'd be magic! But I am fine with the Transfinite2D suggestion, seems fitting, just most generators tend to be 2D without naming it as such, and didn't want to diverge or generate extra work.
they do have to correspond. so registerMooseObject("MooseApp", Transfinite2DMeshGenerator)
but since you generate meshes from 4 points, maybe '2D' is still too general
they do have to correspond. so registerMooseObject("MooseApp", Transfinite2DMeshGenerator)
but since you generate meshes from 4 points, maybe '2D' is still too general
Well it's not too general cause transfinite requires 4 edges, it actually magically works for DISCRETE to do any other domain, but there are still limitations like same number of points on opposite sides.
The test for naming for me would be: how would you call the next generator that can do transfinite meshes from an arbitrary number of sidesets (in 2D for example)
This is a good opportunity to get comfortable with adding stuff to the
large_mediasubmodule - all of the images should be there and be removed from historyYou spotted it right away, I wanted to do large_media but got caught up in the submodule and given the small size I hoped I can get away without. :)
In general any "media" that isn't required for running the test harness we want in large_media, unfortunately 😆
@sapitts would you mind taking a final review at the documentation since you're the most comfortable with this?
I can probably find time to review this over the break; it's definitely ready for review? IIRC the last time I checked it was still showing CI failures but apparently I should have been checking again more recently...
What’s the status of this?
still very much a desired capability! I sent @oanaoana another set of STM generated geometry sets for testing (that had been misbehaving for me) because I was having trouble narrowing down the cases when the circarc option had trouble calculating the radius--I think that debugging work might be ongoing?
Job Precheck on 93ba3ec wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/docs/PRs/21904/clang_format/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format 1542ca05a186584a315c5643fec9329c9d2b5478
