moose
moose copied to clipboard
idaholab
Adding FVFunctorNeumannBC and FVFunctorConvectiveHeatFluxBC
@snschune
Reason
Necessary to transfer functors between multiapps, particularly from finite element to finite volume
Design
New classes added
Impact
None
The heat convection BC should go in modules/heat_conduction probably. This is the heat_transfer module, to rename one day.
Please not we already have a convection+radiation+conduction combined BC, it just uses a constant rather than a functor. You may want to also enable functors for that one.
Moved to modules/heat_conduction and the combined BC is noted. I will attempt to enable functors for it in the future once the other boundary conditions are good.
Job Documentation on 9ddd199 wanted to post the following:
View the site here
This comment will be updated on new commits.
Changes have been submitted by commit, including moving FVFunctorConvectiveHeatFluxBC to heat_conduction module, clean up, fixing of typos, and minor changes to the tests
Job Coverage on db43270 wanted to post the following:
Framework coverage
| f4d49d | #21668 db4327 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 84.52% | 84.52% | +0.00% | 100.00% | |
| Hits | 81534 | 81548 | +14 | 13 | |
| Misses | 14935 | 14934 | -1 | 0 | |
Modules coverage
Heat conduction
| f4d49d | #21668 db4327 | ||||
|---|---|---|---|---|---|
| Total | Total | +/- | New | ||
| Rate | 89.74% | 89.79% | +0.05% | 100.00% | |
| Hits | 3394 | 3414 | +20 | 20 | |
| Misses | 388 | 388 | - | 0 | |
Full coverage reports
Reports
-
framework -
chemical_reactions -
combined -
contact -
electromagnetics -
external_petsc_solver -
fluid_properties -
fsi -
functional_expansion_tools -
geochemistry -
heat_conduction -
level_set -
misc -
navier_stokes -
optimization -
peridynamics -
phase_field -
porous_flow -
ray_tracing -
rdg -
reactor -
richards -
scalar_transport -
solid_properties -
stochastic_tools -
tensor_mechanics -
thermal_hydraulics -
xfem
This comment will be updated on new commits.
@cticenhour I don't understand the SQA error here. The files are where they should be but the error message indicates that they should be located in framework/doc.
Job Precheck on 5ab5f83 wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/docs/PRs/21668/clang_format/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format 004f3bd8409919b662f8e5020b65aa6c4bd9f40b
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
@lindsayad for the review please should this pass the tests. I ended up changing a few things but not very many.