moose
moose copied to clipboard
Adding Lead and LeadBismuth Fluid properties
Used the known equations from "Handbook on Lead-bismuth Eutectic Alloy and Lead Properties "(2015). Added the known formulations for Rho, mu, cp, k and h. While adding other formulation that are needed.
Job Precheck on 6a85914 wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/docs/PRs/21503/clang_format/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format 8fedb09579441fa44a3b4a6b3c28230eaeecb9b2
Job Documentation on ffd4211 wanted to post the following:
View the site here
This comment will be updated on new commits.
Job Coverage on ffd4211 wanted to post the following:
Framework coverage
Coverage did not change
Modules coverage
Fluid properties
e4507b | #21503 ffd421 | ||||
---|---|---|---|---|---|
Total | Total | +/- | New | ||
Rate | 84.82% | 85.37% | +0.55% | 96.68% | |
Hits | 6322 | 6671 | +349 | 349 | |
Misses | 1131 | 1143 | +12 | 12 |
Full coverage reports
Reports
-
framework
-
chemical_reactions
-
combined
-
contact
-
electromagnetics
-
external_petsc_solver
-
fluid_properties
-
fsi
-
functional_expansion_tools
-
geochemistry
-
heat_conduction
-
level_set
-
misc
-
navier_stokes
-
optimization
-
peridynamics
-
phase_field
-
porous_flow
-
ray_tracing
-
rdg
-
reactor
-
richards
-
scalar_transport
-
solid_properties
-
stochastic_tools
-
tensor_mechanics
-
thermal_hydraulics
-
xfem
This comment will be updated on new commits.
Job Coverage on ad39a81 wanted to post the following:
The following coverage requirement(s) failed:
-
fluid_properties
coverage rate 81.32% is less than the required 84.0%
Should be mostly correct now. This needs extensive unit testing to make sure it's 100% correct.
Job Precheck on c976eed wanted to post the following:
Your code requires style changes.
A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:
curl -s https://mooseframework.inl.gov/docs/PRs/21503/clang_format/style.patch | git apply -v
Alternatively, with your repository up to date and in the top level of your repository:
git clang-format 0cdc064aa7d73392645a1a4f995a9a08497cd5a7
@joshuahansel should be good for review if you have time
Review should be addressed now
Thanks for the review!