moose icon indicating copy to clipboard operation
moose copied to clipboard

Porosity and smoothed porosity changes

Open GiudGiud opened this issue 2 years ago • 4 comments

Keeping both around. First stab at it

GiudGiud avatar Jul 04 '22 05:07 GiudGiud

Job Documentation on 7b05beb wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild avatar Jul 15 '22 01:07 moosebuild

Something still not quite right when _smoothing_layers is nonzero

lindsayad avatar Jul 16 '22 17:07 lindsayad

If you're not quite sure what's going on here, I can probably resolve it

lindsayad avatar Aug 02 '22 15:08 lindsayad

Job Coverage on 7b05beb wanted to post the following:

Framework coverage

10e5c0 #21491 7b05be
Total Total +/- New
Rate 84.26% 84.26% +0.00% 100.00%
Hits 79693 79717 +24 23
Misses 14891 14890 -1 0

Diff coverage report

Full coverage report

Modules coverage

Navier stokes

10e5c0 #21491 7b05be
Total Total +/- New
Rate 85.44% 85.45% +0.01% 95.83%
Hits 9747 9753 +6 23
Misses 1661 1661 - 1

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

moosebuild avatar Aug 13 '22 19:08 moosebuild

@lindsayad Pgh patch ready

I added a debug functor functionality. It s not the most detailed thing, but it really really helped debugging what was going on with this PR. I was using porosity instead of smoothed_porosity in some objects in Pronghorn & in NSFV action and could not figure it out

GiudGiud avatar Sep 17 '22 05:09 GiudGiud

what about these other failures?

lindsayad avatar Sep 17 '22 17:09 lindsayad

Probably unrelated I think I have a PR up for that stochastic tool failure we re seeing

GiudGiud avatar Sep 17 '22 19:09 GiudGiud

Haha did you even look? Two of the failures are from your show_functors test

lindsayad avatar Sep 18 '22 23:09 lindsayad

Review should be addressed now

GiudGiud avatar Sep 20 '22 02:09 GiudGiud

still need to fix those failures

lindsayad avatar Sep 20 '22 21:09 lindsayad

ok let s see how this goes

GiudGiud avatar Sep 20 '22 21:09 GiudGiud