moose
moose copied to clipboard
Porosity and smoothed porosity changes
Keeping both around. First stab at it
Job Documentation on 7b05beb wanted to post the following:
View the site here
This comment will be updated on new commits.
Something still not quite right when _smoothing_layers
is nonzero
If you're not quite sure what's going on here, I can probably resolve it
Job Coverage on 7b05beb wanted to post the following:
Framework coverage
10e5c0 | #21491 7b05be | ||||
---|---|---|---|---|---|
Total | Total | +/- | New | ||
Rate | 84.26% | 84.26% | +0.00% | 100.00% | |
Hits | 79693 | 79717 | +24 | 23 | |
Misses | 14891 | 14890 | -1 | 0 |
Modules coverage
Navier stokes
10e5c0 | #21491 7b05be | ||||
---|---|---|---|---|---|
Total | Total | +/- | New | ||
Rate | 85.44% | 85.45% | +0.01% | 95.83% | |
Hits | 9747 | 9753 | +6 | 23 | |
Misses | 1661 | 1661 | - | 1 |
Full coverage reports
Reports
-
framework
-
chemical_reactions
-
combined
-
contact
-
electromagnetics
-
external_petsc_solver
-
fluid_properties
-
fsi
-
functional_expansion_tools
-
geochemistry
-
heat_conduction
-
level_set
-
misc
-
navier_stokes
-
peridynamics
-
phase_field
-
porous_flow
-
ray_tracing
-
rdg
-
reactor
-
richards
-
solid_properties
-
stochastic_tools
-
tensor_mechanics
-
thermal_hydraulics
-
xfem
This comment will be updated on new commits.
@lindsayad Pgh patch ready
I added a debug functor functionality. It s not the most detailed thing, but it really really helped debugging what was going on with this PR. I was using porosity instead of smoothed_porosity in some objects in Pronghorn & in NSFV action and could not figure it out
what about these other failures?
Probably unrelated I think I have a PR up for that stochastic tool failure we re seeing
Haha did you even look? Two of the failures are from your show_functors
test
Review should be addressed now
still need to fix those failures
ok let s see how this goes