moose icon indicating copy to clipboard operation
moose copied to clipboard

Add linear interpolation of tabulated fluid properties, and v,e variable set

Open spaubt2 opened this issue 2 years ago • 1 comments

Refs #20101

Created BidimensionalInterpolation source and header file. This holds syntax that is the same between Bicubic and Bilinear Interpolation. Added sampleDerivative to Bilinear Interpolation to calculate derivatives at points.

TFP inherits from TabulatedBicubicFluidProperties and TabulatedBilinearFluidProperties. User can choose desired type of interpolation in the input file.

Added regression tests to TFP for BilinearInterpolation.

Updated TFP.md file to explain difference in Bicubic/Bilinear and new v,e capabilities

The unit testing is held up because of templating issues. We can try again once gtest contrib is updated

spaubt2 avatar Jun 14 '22 16:06 spaubt2

Job Precheck on 66e23e2 wanted to post the following:

The following commit(s) contain fixups:

  • 942713309e: fixup! fixed e_from_p_rho to get the correct derivatives. Implemented derivatives for T(p,rho) using finite difference method. Added feature to TBicubicFP to allow user to choose whether to get p and T from v,e or v,h or choose to use both.

moosebuild avatar Jul 12 '22 16:07 moosebuild

Any timeline for the gtest contrib update so this PR could get into the main branch? Quite nice PR!

veeshy avatar Sep 08 '22 15:09 veeshy

I ll work on it this coming week. We ll probably do a separate PR for gtest

GiudGiud avatar Sep 11 '22 21:09 GiudGiud

Superseded by https://github.com/idaholab/moose/pull/22060 which is merged now.

@veeshy fyi please reach out if you encounter any issue using it.

GiudGiud avatar Sep 19 '22 23:09 GiudGiud