screp icon indicating copy to clipboard operation
screp copied to clipboard

"Unload" cmd mentioned twice

Open captain-majid opened this issue 2 years ago • 1 comments

https://github.com/icza/screp/blob/b35f110c66f27653d922fc2e748420fa08d34df1/rep/repcmd/types.go 2 items there are named the same name "Unload", I think you should distinguish one from the other ? bc sometimes the cmd "Unload" refers to transport unit unload (Shuttle, Dropship, Overlord), and sometimes it's a Bunker unload. Not sure if it solves the problem but still better.

captain-majid avatar Nov 01 '23 20:11 captain-majid

Afaik the same command may be used for both, and whether it's "Bunker unload" or "Dropship unload" depends on what unit is selected (which cannot be determined in all cases for certain just from a saved replay).

icza avatar Nov 02 '23 13:11 icza