markd icon indicating copy to clipboard operation
markd copied to clipboard

Published 20 hours ago • verified publisher icon icyleaf

GFM support

Open icyleaf opened this issue 7 years ago • 9 comments

Spec: https://github.github.com/gfm/

TODO

  • [ ] task list
  • [ ] table
  • [ ] emoji

icyleaf avatar Jul 13 '17 03:07 icyleaf

Will this include dimensions for images? Usually done via:

![](https://imageurl.com =500x500)

drum445 avatar Mar 12 '19 15:03 drum445

Until this is added I do have support for gfm in my octokit.cr shard. The downside is that it has to make http requests to github's api, but it works.

watzon avatar Jun 20 '19 01:06 watzon

Smart, but the best solution is to use javascript markdown library for now 🤣

icyleaf avatar Jun 25 '19 02:06 icyleaf

I really hope that GFM is added soon to markd. In the meantime, I created a cr-cmark-gfm, a shard that binds to the official GFM C library. You can render to multiple formats, create custom nodes, renderers, etc. If you need full support of GFM in crystal give it a try. PRs welcome!

amauryt avatar Oct 14 '19 09:10 amauryt

Emoji does not appear to really be part of cmark-gfm, FWIW per: https://github.com/github/cmark-gfm/issues/75 Guess that leaves tables and task-lists.

nanobowers avatar Jul 11 '21 01:07 nanobowers

Tables are probably the most commonly used feature of GFM. They're dearly missed in markd.

straight-shoota avatar Mar 15 '22 11:03 straight-shoota

I'm currently focused on my work and no more time on Crystal language, as I mentioned before I would like to donate the project to crystal officials.

Sorry about this :smiling_face_with_tear:

icyleaf avatar Mar 21 '22 08:03 icyleaf

Just to be clear, my comment was not a request for you to take care of this.

Why don't you start a discussion about transferring ownership of the project? I think https://forum.crystal-lang.org/ would be a good place to find a solution for a community-supported new home.

I'm sure we'll find a good way to move forward. markd is an important piece of Crystal's ecosystem. Thank you very much for creating it and taking care of it!

straight-shoota avatar Mar 21 '22 09:03 straight-shoota

I've started working on this here. So far I've done strikethrough, hope to get to the rest soon.

  • [ ] tables
  • [x] task list
  • [x] strikethrough
  • [ ] autolinks
  • [x] disallow raw html (don't know if we should do this one)
  • [x] emoji (not part of gfm but I think would be fun to implement)

nobodywasishere avatar Mar 27 '24 14:03 nobodywasishere