Joseph
Joseph
Ah :D I think this PR is ready for some serious merging considerations :100:
Do you have any link, or source to check this claim? > NPM recently removed the ability for users to report compromised packages Because it looks to me like I...
> Thank you @icyJoseph — the implementation looks great! One more thing I think we should include in the test is reflecting the `updatedAt` state change in other hooks, that...
I agree with your last point there. Just as an update, over the holidays I wrote a test to check that other hooks consuming `key` should update their `updatedAt` key...
Now I am back from my break. I see I've been making an error on my tests. Mostly the call to mutate, and expecting that calls to it should reflect...
@shuding how do you feel about the PR now? I think we just need to decide a name for the prop: > It would be helpful to introduce a new...
@shuding Alright, then should we wait on your PR first, and then adapt this branch to that?
`updatedAt` then should be equal to `Date.now` right after the concurrent promise for this key resolves? ```ts startAt = CONCURRENT_PROMISES_TS[key] newData = await CONCURRENT_PROMISES[key] newState.updatedAt = Date.now() ``` Of course...
Hi, This is indeed hard to trigger, I tried but couldn't. A few observations: - Why does your fetcher, execute with `""`? Even with `[""]` the fetcher should not be...
Ah, and the SWR version? I am not sure I see the problem here, please do help me understand. `key` has the `ALL_ACTIVE` portion, while `keyRef.current` does not, isn't that...