AntAlmanac
AntAlmanac copied to clipboard
GPA column doesn't work in added courses pane
Description
- The GPA column is there but is always empty.
- When you search for the class in the search pane, the GPA column shows up properly.
- When you come back to the added pane, the number for that course is there.
Diagnosis
- There is a parameter in the method that handles querying for courses which controls whether to only read from the cache or check upstream from the API.
- This is so that the search pane can send a batch query to the API instead of the courses individually querying.
- The bug is most likely caused by the fact that the GPA API call is not triggered by a search, then the section table cells search the cache, finds nothing, and the query is not propagated to the API because that parameter is not toggled.
- This should be fixable by simply by passing
true
into that parameter. - However, we should quickly check for query deduplication. I think I implemented something that stops duplicate queries when one is in-flight, but we should check.
- This should be fixable by simply by passing