SharpZipLib icon indicating copy to clipboard operation
SharpZipLib copied to clipboard

Release v1.4.0

Open piksel opened this issue 3 years ago • 6 comments

this branch contains changes needed for the upcoming release, mainly related to .NET 6

The new target frameworks will be:

  • .NET Standard 2.0 (for .NET framework 4.6.2+)
  • .NET Standard 2.1 (general support for all but .NET framework)
  • .NET 6.0 (new LTS)

the main issue stems from the fact that the AES auth code reading is handled inside a class inheriting from CryptoStream. For that to work correctly, the reads cannot be bypassed by more efficient code (which is what is happening in the .NET 6 version of CryptoStream). In fact, the entire ZIPAESStream should probably just be removed altogether, since it seems to just be a work around for having the auth code appended to the input stream. this can be handled much easier in the TransformLastBlock method of ZipAESTransform.

that approach is now used by async reads on .NET 6.0, but others still use the legacy code. this was done to do as little as possible to allow SharpZipLib to work with .NET 6, but it really ought to be replaced for all usages.

piksel avatar May 24 '22 14:05 piksel

Codecov Report

Merging #755 (e76dc02) into master (519ed73) will increase coverage by 0.08%. The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   74.60%   74.68%   +0.08%     
==========================================
  Files          72       72              
  Lines        8457     8447      -10     
==========================================
  Hits         6309     6309              
+ Misses       2148     2138      -10     
Impacted Files Coverage Δ
...ICSharpCode.SharpZipLib/Encryption/ZipAESStream.cs 84.28% <ø> (ø)
...ib/Zip/Compression/Streams/DeflaterOutputStream.cs 82.47% <ø> (+7.70%) :arrow_up:
...harpCode.SharpZipLib/Encryption/ZipAESTransform.cs 88.46% <82.35%> (-0.63%) :arrow_down:
src/ICSharpCode.SharpZipLib/Core/EmptyRefs.cs 100.00% <0.00%> (ø)
.../ICSharpCode.SharpZipLib/BZip2/BZip2InputStream.cs 74.70% <0.00%> (+0.30%) :arrow_up:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov[bot] avatar May 24 '22 15:05 codecov[bot]

Can I get it from nuget?

tonyliving avatar Jun 01 '22 01:06 tonyliving

@tonyliving not until it has been released, no. If you want to try it out you can download the build artifact for this PR: https://github.com/icsharpcode/SharpZipLib/suites/6639150865/artifacts/250580285

piksel avatar Jun 01 '22 09:06 piksel

@piksel Me again 🙈 Is there something blocking this from being released?

carlreid avatar Jul 06 '22 10:07 carlreid

No, It's mainly because of me being busy with work. Sorry.

piksel avatar Jul 06 '22 17:07 piksel

No worries, take it easy 😊

carlreid avatar Jul 06 '22 17:07 carlreid

It seems the artifact from the previous build has expired, is it possible you could re-trigger the build / release this version?

Was just about to host the pre-release package so we could make use of the fix https://github.com/icsharpcode/SharpZipLib/pull/750

carlreid avatar Sep 14 '22 07:09 carlreid

@carlreid I fixed the conflict and there should be a new artifact to download. Also, I fixed the last PR that was blocking release, so it should be ready by the weekend.

piksel avatar Sep 15 '22 10:09 piksel

Wonderful! Thank you 😊

In which case, I'll wait until next week to see if you managed to make it through with a release before trying to host the artifact.

carlreid avatar Sep 15 '22 10:09 carlreid