SharpZipLib icon indicating copy to clipboard operation
SharpZipLib copied to clipboard

Add support for old Info-ZIP extra block for Unix

Open bastianeicher opened this issue 4 years ago • 1 comments

SharpZipLib currently supports reading timestamps from the "Extended Timestamp Extra Field" (0x5455).

This PR adds support for the older (but still often seen in new .zip files) "Info-ZIP Unix Extra Field (type 1)" (0x5855).

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

bastianeicher avatar Sep 07 '21 09:09 bastianeicher

Codecov Report

Merging #660 (cef5453) into master (cd5310f) will decrease coverage by 0.24%. The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   73.28%   73.04%   -0.25%     
==========================================
  Files          68       68              
  Lines        8304     8339      +35     
==========================================
+ Hits         6086     6091       +5     
- Misses       2218     2248      +30     
Impacted Files Coverage Δ
src/ICSharpCode.SharpZipLib/Zip/ZipExtraData.cs 69.04% <9.37%> (-7.29%) :arrow_down:
src/ICSharpCode.SharpZipLib/Zip/ZipEntry.cs 90.59% <66.66%> (-0.32%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cd5310f...cef5453. Read the comment docs.

codecov[bot] avatar Sep 07 '21 09:09 codecov[bot]