SharpZipLib icon indicating copy to clipboard operation
SharpZipLib copied to clipboard

[WIP] Alternate approach to async reads in ZipAESStream

Open Numpsy opened this issue 4 years ago • 1 comments

Alternate approach to #576 which tries taking the simpler approach of using the 'useAsync' idea that some MS libs use for sharing async/sync versions of a function instead of duplicating all the logic, in order to only have a single version of ReadAndTransform

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

Numpsy avatar May 08 '21 21:05 Numpsy

Codecov Report

Merging #624 (f8b19ed) into master (e1e1a91) will increase coverage by 0.05%. The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #624      +/-   ##
==========================================
+ Coverage   73.82%   73.87%   +0.05%     
==========================================
  Files          69       69              
  Lines        8291     8311      +20     
==========================================
+ Hits         6121     6140      +19     
- Misses       2170     2171       +1     
Impacted Files Coverage Δ
...ICSharpCode.SharpZipLib/Encryption/ZipAESStream.cs 84.61% <92.85%> (+0.32%) :arrow_up:
src/ICSharpCode.SharpZipLib/Core/StreamUtils.cs 51.78% <100.00%> (+5.78%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1e1a91...f8b19ed. Read the comment docs.

codecov[bot] avatar May 08 '21 21:05 codecov[bot]