SharpZipLib icon indicating copy to clipboard operation
SharpZipLib copied to clipboard

[WIP] Add an implementation of ReadAsync to ZipAESStream

Open Numpsy opened this issue 4 years ago • 1 comments

refs #572

Add an implementation of ReadAsync to ZipAESStream, with associated StreamUtils change and a copy/pasted unit test (that currently fails on .NETCore 3.1 due to #572).

WIP because:

  1. There is still a bunch of duplication between ReadAndTransform/ReadAndTransformAsync, and the copy/pasted signature of TransformFromSlideBuffer doesn't feel ideal.

  2. Looking at ZipFile.GetInputStream a bit more, I don't think it will actually do async reads from the base stream unless PartialInputStream is given some async support as well, so the current code might not actually be any 'more' async that just making ReadAsync call Read synchrounously and then returning the result.

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for the SharpZipLib open source product (the "Contribution"). My Contribution is licensed under the MIT License.

Numpsy avatar Feb 14 '21 16:02 Numpsy

just making ReadAsync call Read synchrounously and then returning the result

which would be the fastest change if we want a fix ASAP, but not as nice as a real async impl, which fits in more with the other async supporting changes.

Numpsy avatar Feb 14 '21 17:02 Numpsy