fake icon indicating copy to clipboard operation
fake copied to clipboard

Fix english name prefix/suffix

Open slowteetoe opened this issue 8 years ago • 2 comments

The name prefix/suffix files for english were formatted incorrectly, so all options would be returned instead of choosing from one of options.

e.g. fake.MaleFullNameWithSuffix() would return 'John Smith Jr. Sr. I II III IV V MD DDS PhD DVM' instead of 'John Smith MD'

It also seems that the way esc works with this project may have changed. When you run 'go generate' now, everything is prefixed with '_esc'. This was causing a compile error in fake.go

slowteetoe avatar May 27 '16 23:05 slowteetoe

@icrowley can we merge this?

novembrea avatar Aug 11 '17 09:08 novembrea

@nvma At this time - no, it should be refactored because it doesn't follow the Go idioms about naming. I am refactoring the whole package now and it probably will be finished in 2 weeks.

corpix avatar Aug 11 '17 11:08 corpix

we could really just merge this. it's been a bit more than 2 weeks ;)

kazamatzuri avatar Nov 12 '22 05:11 kazamatzuri

Haha, yeah, sorry. Let it be, lets merge this

corpix avatar Nov 12 '22 15:11 corpix

only problem: this is not the whole change. to also change it when it's not reading it from the files, we also need to update the compressed representation of the files. Similar to here: https://github.com/kazamatzuri/fake/commit/db3b860caf1971acb2a188ed81ab3c2afc4223e9

kazamatzuri avatar Nov 13 '22 06:11 kazamatzuri