pyvat icon indicating copy to clipboard operation
pyvat copied to clipboard

map country codes used by european commission that don't follow the I…

Open tiptop96 opened this issue 5 years ago • 3 comments

…SO 3166-1 alpha-1 standard to their correct expressions

tiptop96 avatar Sep 03 '20 13:09 tiptop96

Please have a look at "Imperfect implementations" third paragraph: https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2

Maybe you don't want duplicate regexes, let me know and I will clean it up.

tiptop96 avatar Sep 03 '20 13:09 tiptop96

Looking closer I see that this is taken care of in the decompose_vat_number function for Greece, however I still think it should have the same logic for GB/UK. I can add this if the maintainer is interested?

tiptop96 avatar Sep 04 '20 08:09 tiptop96

This is moot now, but for the record (I got quite confused for a while after reading this issue), the EU did use the official ISO 3166-1 alpha-2 code for the United Kingdom, GB. The UK uses the .uk TLD though, but that is a different can of worms.

Feuermurmel avatar Jan 04 '21 16:01 Feuermurmel