add to_msgpack method to Ruby Core APIs.

Open taichi opened this issue 11 years ago • 6 comments

Jun 11 '14 06:06 taichi

Thank you for this PR. If we're going to add #to_msgpack I think it must include support for adding the method to your own classes, like suggested in #13.

The idea right now is to try to merge this gem into msgpack/msgpack-ruby, and that means supporting everything that that gem supports, including this. I'll have to see if I'll merge this PR or implement it as part of the merge.

Jun 11 '14 07:06 iconara

this PR cotains very simple case only. this PR don't contain one argment with calling to_msgpack method.

Jun 11 '14 07:06 taichi

This will happen in msgpack/msgpack-ruby#33

Jul 16 '14 06:07 iconara

:+1:

Jul 16 '14 09:07 taichi

:+1:

Sep 19 '14 17:09 miry

Any chance to have it mainline?

Dec 15 '14 00:12 niamster