ResViT icon indicating copy to clipboard operation
ResViT copied to clipboard

Additional dependencies and deprecated functions

Open skarrea opened this issue 1 year ago • 1 comments

Hey and thanks for a great repository. While setting the code up I found that some of the dependencies were missing from the readme. Specifically, these are scikit-image, h5py and ml_collections.

Additionally, in more recent versions of scikit-image, compare_psnr is moved and renamed from skimage.measure.compare_psnr to skimage.metrics.peak_signal_noise_ratio.

In more recent versions of pytorch it also seems that the .cuda(async = ...) keyword is replaced with .cuda(non_blocking = ... ) since async is a reserved keyword in python >= 3.7.

I see two ways to fix the issues; either by being more specific in terms of compatible package versions or, my preferred solution, updating the codebase to new keywords and functions.

I'd gladly submit a pull request with the mentioned changes if you'd like me to. I also made a dockerfile for setting up an environment with the requirements if that should be of any interest.

skarrea avatar Apr 07 '23 09:04 skarrea

I also found that scipy.misc.imresize is deprecated since version 1.3.0 and Image.resize from pillow is suggested to be used instead. And scipy should perhaps also be added as a dependency.

skarrea avatar Apr 07 '23 09:04 skarrea