Ian Colwell

Results 13 issues of Ian Colwell

Some unit tests were disabled in https://github.com/Autoware-AI/utilities/pull/10 and https://github.com/Autoware-AI/utilities/pull/6 since they depended on the system running the test. This was quite fragile and often caused issues with CI. Review these...

Maybe this was intentional, but I just wanted to bring it up: The `autorepeat_rate` param defaults to `0` in ROS1, but defaults to `20` in ROS2 (both joy and joy_linux)....

The `gps/gps` topic publishing [gps_common/GPSFix](http://docs.ros.org/hydro/api/gps_common/html/msg/GPSFix.html) messages is [using](https://github.com/swri-robotics/novatel_gps_driver/blob/master/novatel_gps_driver/src/novatel_message_extractor.cpp#L582) the utc field from the [novatel messages](https://docs.novatel.com/OEM7/Content/Logs/GPGGA.htm) to fill the time field in the ROS message instead of [GPS time](http://leapsecond.com/java/gpsclock.htm).

bug

OEM7 has introduced a new log called [CORRIMUS](https://docs.novatel.com/OEM7/Content/SPAN_Logs/CORRIMUS.htm) which replaces the CORRIMUDATA log. The driver should check the firmware version of the Novatel hardware and then decide which log to...

enhancement

Add pacmod3_common as a submodule and remove any can parsing code from this repo.

Currently the driver will save all the received command messages from the autonomy side and then only send them out over CAN to the PACMod once a rate loop is...

enhancement

Currently the driver leaves a gap of 1 ms between CAN msgs sent to the PACMod. The PACMod protocol documentation suggests this pause should be more like 0.5 ms: https://github.com/astuff/pacmod_dbc/blob/11.6.0/doc/user_can_protocol.md#rules-for-transmitting-can-messages...

Change all `unsigned int` uses to `uint32_t`. Also auto-format the entire codebase using clangformat.