Ian Clanton-Thuon

Results 106 comments of Ian Clanton-Thuon

The way this code was merged into main is slightly weird (it was a cherry-pick from a `rush-next` branch about eight years ago), so I'm not finding any PR discussion...

@tianmagongyue - did you create a fork of this repo and push your feature branch there? You shouldn't need any permissions to create a PR from a fork.

Make sure you include a `LICENSE` file like this one: https://github.com/microsoft/rushstack/blob/main/rush-plugins/rush-serve-plugin/LICENSE

@fahmifan - We encountered a number of issues with NPM over the years, so supporting it hasn't been a priority. We'd happily take a PR to update support for NPM,...

@aramissennyeydd - Looks good overall. Once you just address @dmichon-msft's comments we can get this in.

Which `.npmrc` file are you sticking the credentials in? I'm not particularly familiar with how Artifactory's authentication works, there may be quirks in how it expects credentials. Can you try...

From that error message, it sounds like the token that you're using isn't correct. Specifically this line: > `51 error Unable to authenticate, your authentication token seems to be invalid.`...

You can try changing the format to `//(internal server name)/:_authToken=Bearer (base-64 encoded string)`. This doesn't seem like specifically a Rush issue at this point - I'm pretty sure Artifactory just...

The Verdaccio documentation (https://verdaccio.org/docs/authentication/) mentions that authentication is controlled by which authentication plugin you're using. Which plugin are you using?

`rush change` needs the merge base to correctly determine which projects were changed. Is there a reason you can't clone with a depth of two?