factions icon indicating copy to clipboard operation
factions copied to clipboard

Add different radar style

Open PyPylia opened this issue 3 years ago • 5 comments

Is your feature request related to a problem?

Currently, the radar only displays in the action bar. Some players may prefer other alternative methods.

Describe the solution you'd like.

  • Setting to display the faction name as a title when entering/exiting a claim, and the faction description in the subtitle.
  • Setting to refresh the faction map in chat when entering/exiting a new chunk(s).

Describe alternatives you've considered.

None

Other

Inspired by svr333/FabricFactions@50aa2c2b5e3bca810d104097aaa0e3d2c45c9516

PyPylia avatar Jul 02 '22 15:07 PyPylia

if you want, I can PR the title one into this repo

svr333 avatar Jul 04 '22 09:07 svr333

If it was toggleable by a config value or settings command that would be great. Additionally, I don't think constructing a /title command is the most effective way of doing it, try looking at the source for TitleCommand to see how Mojang implemented it.

PyPylia avatar Jul 04 '22 10:07 PyPylia

well a user requested the old radar back, so I now have a toggle for both of them. /f settings radar for the title one and /f settings legacyRadar for the actionbar radar.

Title radar is also enabled by default now.

Additionally, I don't think constructing a /title command is the most effective way of doing it

This is probably very true, but I'm very new to fabric development and I couldn't find the documentation I was looking for online, so I resorted to using the commands I already knew

Anyway, feel free to copy any of my code/ideas and use it

svr333 avatar Jul 04 '22 10:07 svr333

Sounds good, probably would want to combine them into one command and use an enum, like how the chat and sound settings work. Additionally, I don't think legacy is the greatest name for it, might want to do something like /f settings radar actionbar and /f settings radar title. As for documentation, reading implementations for Mojang commands is actually a really good way to learn. The specifics of decompiling the source are different for each IDE, just search up the fabric wiki and read their pages on setting up a development environment, and maybe skim through a tutorial or two.

PyPylia avatar Jul 04 '22 10:07 PyPylia

Will do, thanks for the tips :)

svr333 avatar Jul 04 '22 10:07 svr333