hnnotifications icon indicating copy to clipboard operation
hnnotifications copied to clipboard

Add regex expression as additional filter

Open lambtron opened this issue 11 years ago • 4 comments

https://news.ycombinator.com/item?id=8649261

I think it would be cool to allow users to save a regex with their point threshold. Any stories that match both will be sent to the user.

I was going to make this, but came across your project. I'm not 100% familiar with Go or otherwise i'd fork and submit a PR :).

Thoughts?

lambtron avatar Nov 30 '14 04:11 lambtron

Hi @lambtron,

I actually had something similar in mind. Not exactly with regex-based filters, but simply with user-defined keywords. I feel that adding regex support, although not technically difficult from an implementation point of view, it could perhaps get too complex for a basic filter usage? i.e. not every user has a deep understanding of them, the syntax varies from one programming language to another, etc.

ichinaski avatar Dec 06 '14 17:12 ichinaski

Hey thanks for your comment. Yeah you are right, maybe just basic filtering would suffice. The most complex would probably be contains X or Y maybe also excluding Z.

Regardless, any plans to add that? Would be cool! Thanks for making this!

lambtron avatar Dec 06 '14 18:12 lambtron

I finally got round to implementing this feature. You can now optionally subscribe to one or more keywords, getting notifications from any story that matches any of your keywords. It might be a bit naive for now, but it does the trick.

ichinaski avatar Mar 28 '15 12:03 ichinaski

Super cool :) love this service! Thanks for making this.

lambtron avatar Mar 28 '15 14:03 lambtron