Ian Faust

Results 551 comments of Ian Faust

> @icfaust By the way, since now we have versioned docs of sklearnex with all the available versions since 2024.7, and we have a `__version__` attribute for sklearnex, the extension...

> @icfaust It would be quite helpful in all of these changes to have type hints in the function signatures. I realize the current codebase hardly uses them, but this...

> @icfaust The last commit fixed the issue for the doclinks, but some things are still not working correctly when subclassing. For example, this doesn't work: > > ```python >...

http://intel-ci.intel.com/f01b91e9-a110-f123-b04f-a4bf010d0e2d

@samir-nasibli Unfortunately there is a subtlety to "support" vs "known to work" which is described in the linked sklearn documentation. What seems to be the issue is that dpnp/dpctl are...

I was sort of hoping we could leave a reminder to ourselves ```python @pytest.mark.allow_sklearn_fallback @pytest.mark.skipif(not sklearn_check_version("1.4"), reason="requires sklearn array_api support") @pytest.mark.parametrize("dataframe,queue", get_dataframes_and_queues("dpnp,dpctl", "cpu")) def test_sua_fallback_support(dataframe, queue, monkeypatch): '''This test verifies...