Ian Faust comments

Results 551 comments of


                                            Ian Faust

[bug] fix MT2203 RNG non-uniformity and random bin indices in decision forest training

Private CI shows this causes an issue with ExtraTreesClassification now, will need to investigate

[bug] fix MT2203 RNG non-uniformity and random bin indices in decision forest training

/intelci: run ml_benchmarks

Basic statistics allow computation on sparse data and add test

Please add this to run_to_run_stability sparse stability testing.

Cannot visualize a tree plot with ExtraTrees and Randomforest classifiers

Hey @YoochanMyung . I wanted to let you know that I am working on your issues, and will write you in the next days.

Cannot visualize a tree plot with ExtraTrees and Randomforest classifiers

Hello @YoochanMyung . I am so sorry about the delay on your issue. PR #2377 should fix the issue, as our construction of the decision trees incorrectly values the estimators...

[CI, enhancement] track bazelisk using renovatebot

/azp run CI

[CI, enhancement] track bazelisk using renovatebot

@homksei superceded by #3383

[WIP] Remove deselection of sparse sigmoid kernels tests

@Vika-F I am starting to mess with these tests and shift them out of the onedal folder. Should we accelerate these changes here or fold them into my PR for...

Change SVM._fit_proba implementation

I think there is a causation issue with switching to 'prefit' on CalibratedClassifierCV (https://stats.stackexchange.com/a/263411), which can explain possible overfitting. Sklearn's SVM is based on the libsvm package (https://www.csie.ntu.edu.tw/~cjlin/libsvm/faq.html#/Q06:_Probability_outputs) which also...

Change SVM._fit_proba implementation

@Alexsandruss please send me the ticket for the follow-up development based off of this PR. I would have liked to see documentation within the code related to the changes and...