remote-ftp icon indicating copy to clipboard operation
remote-ftp copied to clipboard

.ftpignore doesn't work when I ignore folder

Open GNXB opened this issue 8 years ago • 31 comments

[remote-ftp version: 1.1.3 on Atom 1.20.0 x64 OS X El Capitan] I has a large folder size on the remote machine and I want to prevent downloading it to my working machine. But when I perform Right-Click on remote-ftp panel at the root folder and click "Download" or "Sync Local <- Remote", then it performs downloading all of files and folders also "The Large One" to my machine.

Now I can done is Manually download each sub folder (Right Click -> Download several times)

Here is my .ftpignore file. Does I config it correctly? Thank you. screen shot 2560-09-19 at 12 28 10 pm

GNXB avatar Sep 19 '17 05:09 GNXB

Same here on Linux. .ftpignore is (ironically) ignored.

guitarbeerchocolate avatar Oct 05 '17 10:10 guitarbeerchocolate

I have issues with every folder and .ftpignore itself, they all get uploaded to the server.

ghost avatar Oct 23 '17 17:10 ghost

Sad to see this bug ignored for a Month now.. Ignoring a folder shouldn't be that difficult to implement. I dont want to sync the whole node_modules folder everytime.. For everyone with the same problem i can recommend remote-sync, ignoring works for folders and files and watching works for files. Although im still waiting for the feature to set wildcards for watching, but as im aware they're working on it. oh and its a bit faster than remote-ftp

PhKi avatar Oct 23 '17 23:10 PhKi

If it is not difficult for you, next time we wait for your pull request.

It works for all downloads. https://github.com/icetee/remote-ftp/commit/344d3af7c153fec78745d1d5ce2a8d769355e611

Upload soon ...

icetee avatar Oct 24 '17 02:10 icetee

@icetee how is this an enchanement? it's a straight up bug. folders (and files within them) are getting uploaded while they are in the .ftpignore, so the ftpignore doesn't work for folders, it's a bug.

ghost avatar Oct 24 '17 13:10 ghost

Unfinished development. The original issue was only downloaded.

icetee avatar Oct 24 '17 14:10 icetee

@icetee but it's also the other way around, whenever I upload index.js (by CMD + S), the node_modules/ folder get's uploaded from local to remote, while in .ftpignore it contains node_modules/

ghost avatar Oct 24 '17 19:10 ghost

@kevzdev After you've typed it into the .ftpignore file, disconnected?

icetee avatar Nov 03 '17 00:11 icetee

Issue still persists. Can't ignore folders. My .ftpignore:

.ftpconfig
.ftpignore
id_rsa
.DS_Store
.git
*/node_modules
sample*

The .git folder is still being synced, as well as the node_modules folder. All files in the root with sample in their names are rightly ignored. Perhaps it is a typo on my behalf. The path of the node_module folder is site/themes/theme/node_modules.

pixelliquid avatar Nov 30 '17 12:11 pixelliquid

@icetee yes, I've disconnected after. Issue still persists. @PeterEmil I have the exact same problem.

ghost avatar Nov 30 '17 14:11 ghost

I ran into the same issue using version 1.2.3 and 2.1.0. You can work around the issue by restarting atom any time you change the .ftpignore file; since it's set to load on start.

I created a PR to address this issue: https://github.com/icetee/remote-ftp/pull/1076/

emoruzzi avatar Dec 07 '17 21:12 emoruzzi

Even restart doesn't work for me. I'm on Windows, if it matters.

FranklinYu avatar Dec 08 '17 03:12 FranklinYu

any updates on this?

rustyforeal avatar Jan 03 '18 22:01 rustyforeal

waiting , how to add a single file on .ftpignore? just type the filename with extension ?

wendyliga avatar Jan 23 '18 05:01 wendyliga

The original issue was for .ftpignore not working on macOS; what version of windows are you having the issue on?

emoruzzi avatar Jan 23 '18 15:01 emoruzzi

Oh thats was the reason , i use mac

wendyliga avatar Jan 23 '18 15:01 wendyliga

@wendyliga The remote-ftp package uses the npm ignore package; which is similar to how a gitignore file would work. https://github.com/icetee/remote-ftp#how-to-use-ftpignore

You can find more information about how to use the ignore file at https://git-scm.com/docs/gitignore

emoruzzi avatar Jan 23 '18 17:01 emoruzzi

@emoruzzi Is this supposed to be a mac-only issue? I’m experiencing same issue on Windows 10.

FranklinYu avatar Jan 23 '18 19:01 FranklinYu

also have the same issue... it messed up stuff that shouldn't be changed on the remote :(

Balloota avatar Feb 17 '18 16:02 Balloota

I'm also having this issue on Mac, even .ftpignore file is being uploaded, however it does show greyed out in the remote file tree.

TomS- avatar Jun 12 '18 11:06 TomS-

Same here, Windows 10. It doesn't matter what I write into the .ftpignore file, it's syncing everything, even itself. Files, folders, everything. It just straight up does not work.

michael-lo avatar Sep 18 '18 08:09 michael-lo

Could it be user permission problem? Mine worked after running Atom as Administrator.

eagl3s1ght avatar Sep 21 '18 07:09 eagl3s1ght

Not likely, I always run Atom with sudo.

michael-lo avatar Sep 21 '18 10:09 michael-lo

06/11/2018 Still not fixed. :/

SZOKOZ avatar Nov 06 '18 21:11 SZOKOZ

Is this issue fixed yet? It's really bad for my SSD to download large files from remote server.

eugenelet avatar Dec 12 '18 16:12 eugenelet

How to prevent specific file upload using ftp ignore. It uploading my all scss files also.

JRudransh avatar Jun 10 '19 14:06 JRudransh

Still Not Fixed??

JRudransh avatar Jun 10 '19 14:06 JRudransh

In my case it works now, after a restart on MacOS

koehlersimon avatar Jul 19 '19 10:07 koehlersimon

same here, like the ignore file didnt exist at all

DuchSuvaa avatar May 07 '20 11:05 DuchSuvaa

Also experiencing this problem (using Atom v1.53 and remote-ftp v2.2.4) on MacOS. All local files, including .ftpconfig and those specified in .ftpignore are uploaded to remote server. This didn't happen in previous versions. I've reinstalled Atom/remote-ftp and restarted my Mac, but it's still not working. Any suggestions welcome.

rossmaidment avatar Jan 06 '21 10:01 rossmaidment

Same issue here for a while. I'm using Atom v1.60.0 and remote-ftp v2.2.4 (macOS).

moerphie avatar Mar 12 '22 18:03 moerphie