icepyx icon indicating copy to clipboard operation
icepyx copied to clipboard

Update issue templates

Open JessicaS11 opened this issue 3 weeks ago • 3 comments

JessicaS11 avatar Dec 05 '25 20:12 JessicaS11

Binder :point_left: Launch a binder notebook on this branch for commit 9de6ac2a5cf4ec9b4d1be5942b9ca6625cddd436

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit bdd021919ea827cbfe69ab75bd09af0dae04b4e0

Binder :point_left: Launch a binder notebook on this branch for commit 57c71a54a986c38633c0a49f20c71ee1128016e0

Binder :point_left: Launch a binder notebook on this branch for commit a0d0c12cb413457a040793d6447d2da7c867e9cf

Binder :point_left: Launch a binder notebook on this branch for commit 0dfeea65f031e8376b0756388d653c57659244a3

Binder :point_left: Launch a binder notebook on this branch for commit 739eac34928fcaa40166a5b3c697c2da8453638c

Binder :point_left: Launch a binder notebook on this branch for commit dcea10972a9f2e11ca56993f1917adee6f3135ad

Binder :point_left: Launch a binder notebook on this branch for commit 989642ada1133c7c3258c5bf3c8fa6324b06f476

Binder :point_left: Launch a binder notebook on this branch for commit f945fd9aca9e0454dc83d94fcf1a443bf7e19753

Binder :point_left: Launch a binder notebook on this branch for commit d95058b848ce60db061c471091966ea0e640ceae

Binder :point_left: Launch a binder notebook on this branch for commit cd8d1768660b46709d5608fcda4bd10e398da63c

Binder :point_left: Launch a binder notebook on this branch for commit 53e29f6008d6ae839b62ecf7ed00b47e9f21ec19

github-actions[bot] avatar Dec 05 '25 20:12 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 65.83%. Comparing base (7251f19) to head (53e29f6). :warning: Report is 1 commits behind head on development.

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #728   +/-   ##
============================================
  Coverage        65.83%   65.83%           
============================================
  Files               37       37           
  Lines             3050     3050           
  Branches           394      394           
============================================
  Hits              2008     2008           
  Misses             971      971           
  Partials            71       71           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Dec 05 '25 20:12 codecov[bot]

I just updated these to be more tailored to icepyx! Changes:

  • feature request template: I didn’t change much other than inserting “icepyx” where the template said “our project”
  • bug report template: I switched to yaml because I wanted to add a bit of new functionality (Ex. having a place where a user could include a code block; specify placeholder text; …)

Ready for review. I just requested @asteiker (@JessicaS11 I can’t request you, I assume because you opened the initial PR).

@JessicaS11 do you have any insight on the failing integration check? The error is User **pre-commit-ci[bot]** does not have permission to run integration tests and it looks like it’s a required check.

rwegener2 avatar Dec 11 '25 17:12 rwegener2

do you have any insight on the failing integration check? The error is User pre-commit-ci[bot] does not have permission to run integration tests and it looks like it’s a required check.

That one is when precommit runs and thus the last commit is from the bot, it doesn't have access to the secrets required for the integration tests. I'm not sure if there's an easy way to fix that. Either way, the integration tests will still fail because I just updated them for v007 file IDs and sizes (#727), but for some reason v006 granules are being returned now (versus last week when I first updated them). I'm working with NSIDC on it.

JessicaS11 avatar Dec 12 '25 20:12 JessicaS11

… though I pasted in the errors that I received when I viewed the file within GitHub

Thanks so much @asteiker, this is really helpful!

~Where did you go to see those error messages? I don’t think I’m seeing them when I just open the file in the “Files Changed” section of the PR~ Nevermind, I found it by viewing the file in the issue-templates branch. Thanks for pointing that out, I didn’t realize you could do that! I’ll go through and fix those syntax errors.

rwegener2 avatar Dec 15 '25 14:12 rwegener2

This looks great, @rwegener2! Thank you! I added a few minor formatting notes, but happy for you to approve and merge this PR whenever.

JessicaS11 avatar Dec 15 '25 15:12 JessicaS11

Thanks for the review @JessicaS11! I updated the templated addressing your comments.

I actually am not allowed to squash and merge, I think because the Integration Test is marked a a required test. Is there a work-around for that?

rwegener2 avatar Dec 15 '25 21:12 rwegener2

@rwegener2 Sorry for missing your question on viewing the files and associated warnings! Glad you found it. Yes I was also able to do this from the PR by clicking on Files Changed tab and clicking the three dots at the top of the file -> View file.

asteiker avatar Dec 17 '25 16:12 asteiker

I actually am not allowed to squash and merge, I think because the Integration Test is marked a a required test. Is there a work-around for that?

I use my admin privileges to check the box allowing us to bypass the rules... not my favorite to use, but until we get them debugged/fixed...

JessicaS11 avatar Dec 17 '25 17:12 JessicaS11