A collection of "low-hanging fruit" refactors
[!IMPORTANT] To be merged only after merging #605 and rebasing
I'm happy to split this in to multiple PRs, but there's a lot of disparate changes here and I didn't want to flood the queue before showing you the whole pile. Let me know!
:point_left: Launch a binder notebook on this branch for commit 91bd9a8bc45f5e5c8548fb6f4331dd46628d3658
I will automatically update this comment whenever this PR is modified
:point_left: Launch a binder notebook on this branch for commit b75d000346e2dba139fea1c1e6ed43a1b763d60b
:point_left: Launch a binder notebook on this branch for commit 2e7ac199569de4a742a362c5f522909cc375670a
:point_left: Launch a binder notebook on this branch for commit e6151d1ba5cfadc46ab66519cdd2adbe7da7f45f
:point_left: Launch a binder notebook on this branch for commit 4dc2872015eff3ad9cec6036a1ca8f7ad9075473
:point_left: Launch a binder notebook on this branch for commit a180892a3f253f52009c7d4c6915195bd521398e
:point_left: Launch a binder notebook on this branch for commit 88459e59994dedba256530f1935cd04f8c600c03
:point_left: Launch a binder notebook on this branch for commit 77112b7943de3bfab06e06db361752f73aaed5d0
Codecov Report
:x: Patch coverage is 79.10448% with 14 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 67.83%. Comparing base (7675584) to head (77112b7).
:warning: Report is 1 commits behind head on typecheck-spatial.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| icepyx/core/is2ref.py | 54.54% | 9 Missing and 1 partial :warning: |
| icepyx/core/query.py | 87.09% | 4 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## typecheck-spatial #612 +/- ##
=====================================================
+ Coverage 67.76% 67.83% +0.06%
=====================================================
Files 36 37 +1
Lines 3149 3146 -3
Branches 430 426 -4
=====================================================
Hits 2134 2134
+ Misses 931 928 -3
Partials 84 84
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Looks like this PR is ready-to-go pending #605
Looks like this PR is ready-to-go pending https://github.com/icesat2py/icepyx/pull/605
Any idea why this shouldn't go directly into development?
Looks like this PR is ready-to-go pending #605
Any idea why this shouldn't go directly into development?
This work is based on what's in #605 . We might be able to pull out the changes from this PR independently if we decide not to move forward with #605 though.
Looks like this PR is ready-to-go pending #605
Any idea why this shouldn't go directly into development?
This work is based on what's in #605 . We might be able to pull out the changes from this PR independently if we decide not to move forward with #605 though.
@trey-stafford @mfisher87 if either of you are able to separate out the changes in the PR that rely on #605 (maybe we can add those directly to #605?) from those that don't, it would be super to get this merged in!
I might be able to take a look in a couple weeks, but can't promise at the moment!