icepyx icon indicating copy to clipboard operation
icepyx copied to clipboard

Typecheck spatial module

Open mfisher87 opened this issue 1 year ago • 7 comments

mfisher87 avatar Sep 10 '24 17:09 mfisher87

Binder :point_left: Launch a binder notebook on this branch for commit e31499094f4a02d7eadbacf64ad072749d72e84c

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 7b563b1be55993bc13b9e5ce5d9238dc4478ac7a

Binder :point_left: Launch a binder notebook on this branch for commit 1f1cfe5ad3d32635aa0e04a02232ae1131187b1c

Binder :point_left: Launch a binder notebook on this branch for commit 749fc03de259d2a5d415a2b16734b97bda32f8bb

Binder :point_left: Launch a binder notebook on this branch for commit a63ae1369ce4cfa5e504364550a11c26491ec735

Binder :point_left: Launch a binder notebook on this branch for commit bfa95624f06a60434c763f73f688c3ed62842cf0

Binder :point_left: Launch a binder notebook on this branch for commit 153c307726b6c64a9805717f14b5bdc5ae158bf9

Binder :point_left: Launch a binder notebook on this branch for commit e0ef9671cb91ca4197fafdd5e0aa0cddc7dc41d8

Binder :point_left: Launch a binder notebook on this branch for commit 130160b92174e6d6859aeeed4e03c45856fb3ec9

Binder :point_left: Launch a binder notebook on this branch for commit 830f471f58de3a70544be92fce10d50881cb7edf

Binder :point_left: Launch a binder notebook on this branch for commit 0ca4485a683cb4a08c122064c4bcd3c541f6a31b

Binder :point_left: Launch a binder notebook on this branch for commit b035695aa27ab6b14c0cb1504984e3720755e8c9

Binder :point_left: Launch a binder notebook on this branch for commit cbc761cc4759b908367d67fda3edc15787f76586

Binder :point_left: Launch a binder notebook on this branch for commit 52037e9d6b4592aa77d631deea2f2df5a4d93f74

Binder :point_left: Launch a binder notebook on this branch for commit 7c6499170766419139d1757380db1fe819e29e9b

Binder :point_left: Launch a binder notebook on this branch for commit 2adc38db13ba6278df00d567b2081d6f34f4d5ab

Binder :point_left: Launch a binder notebook on this branch for commit 9df3ec783a632b494c41972a313432ad08dc6e48

Binder :point_left: Launch a binder notebook on this branch for commit 6f771d83fafe1e56b7e57a0421a10e9acd48263a

Binder :point_left: Launch a binder notebook on this branch for commit 3f923a60e48acbc9c1337092b850e8948311dbab

Binder :point_left: Launch a binder notebook on this branch for commit 27de54847c6c5d2514ea35f7970c30c9b14b615c

Binder :point_left: Launch a binder notebook on this branch for commit 191181eb4f416c9936ff13687c399ff0c8c1b6cd

Binder :point_left: Launch a binder notebook on this branch for commit 9aa54dcd584e7ebb9c7a599ee1749a8a4440dc07

Binder :point_left: Launch a binder notebook on this branch for commit 207be535e19c2e94132177cd940d599653b40cce

Binder :point_left: Launch a binder notebook on this branch for commit c89df2147471fd71dd7c0104b6f4117ef5110a1e

Binder :point_left: Launch a binder notebook on this branch for commit b632617602290f2218425821e724814fcb2d4388

Binder :point_left: Launch a binder notebook on this branch for commit 7675584163d30eee5b902b642bb763f9d92d6305

Binder :point_left: Launch a binder notebook on this branch for commit 7bd668c0093e08eb2b7980beb1bfd3f312ec7181

github-actions[bot] avatar Sep 10 '24 17:09 github-actions[bot]

Codecov Report

Attention: Patch coverage is 94.73684% with 6 lines in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (c454aab) to head (7bd668c). Report is 3 commits behind head on development.

Files with missing lines Patch % Lines
icepyx/core/spatial.py 90.62% 3 Missing and 3 partials :warning:
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #605      +/-   ##
===============================================
- Coverage        71.81%   67.74%   -4.07%     
===============================================
  Files               38       36       -2     
  Lines             3136     3150      +14     
  Branches           426      430       +4     
===============================================
- Hits              2252     2134     -118     
- Misses             774      932     +158     
+ Partials           110       84      -26     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 18 '24 01:09 codecov[bot]

@mfisher87 Any idea if this was rebased after merging #604? Trying to determine where to start for fixing merge conflicts and moving this forward.

JessicaS11 avatar Oct 23 '24 15:10 JessicaS11

Rebased this PR (and #612 and #613) and fixed merge conflicts!

mfisher87 avatar Oct 23 '24 22:10 mfisher87

Rebased this PR (and https://github.com/icesat2py/icepyx/pull/612 and https://github.com/icesat2py/icepyx/pull/613) and fixed merge conflicts!

Thanks, @mfisher87! This PR is pretty close - a few suggestions where we may need to make type adjustments (would love a second set of eyes on these) EDIT: DONE and some notes for some docstring and error message edits.

JessicaS11 avatar Oct 24 '24 15:10 JessicaS11

@JessicaS11 just a heads-up that I am beginning to review and work on the Harmony integration tasks that @mfisher87 started, beginning with this PR. I'll be looking over things here and will try to respond to your comments this afternoon!

trey-stafford avatar Oct 30 '24 19:10 trey-stafford

Not sure about the failing codecov/project check but I have added some additional unit tests to cover branches identified by codecov as not being covered by this PR.

Aside from that issue, this should be ready for re-review!

trey-stafford avatar Oct 30 '24 23:10 trey-stafford