icesat2py
Add try/except to avoid OSError when file is missing wanted variable group
Fixes #576
I am a total newb at ICESat-2 data and have only had limited use of the icepyx repo. It would be worth testing this proposed fix on more standard workflows to ensure it doesn't break normal use cases.
:point_left: Launch a binder notebook on this branch for commit 0cefdf2fac82fb999862c7a83bfd950893c5d901
I will automatically update this comment whenever this PR is modified
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks @jrenrut! Unfortunately we don't have CI running a lot of tests on the read module yet, but I have a script I can run locally to test this fix across a broader range of workflows.
@JessicaS11 that script sounds like a great candidate for an integration test! Do you think it can be automated? I can take that on.
@JessicaS11 that script sounds like a great candidate for an integration test! Do you think it can be automated? I can take that on.
Thanks! It could definitely be automated. The challenge (and reason I never got it integrated) is that it requires data files (which we don't want to add to the repo). It's built to use some of the data files that have been submitted as "edge cases". The tentative plan (might be discussed in some issues along the way? Can't recall offhand) was to use a separate repo (I think we created it, but it's empty) to house the data needed for testing (with a manually triggered update for when new versions are released)... I'll get it on my list to pack all that up and send it to you.