icepyx icon indicating copy to clipboard operation
icepyx copied to clipboard

Testing ATL14 gridded land ice download from earthdata

Open weiji14 opened this issue 2 years ago • 8 comments

Adding unit tests for ATL14 data access via Earthdata, using a region over Svalbard (Iceland is smaller, but bounding box overlaps with Greenland which is big).

Towards resolving #288, but also updating tests behind NSIDC login for the ATL06 dataset by updating from v05 to v06.

weiji14 avatar Mar 06 '22 03:03 weiji14

Binder :point_left: Launch a binder notebook on this branch for commit 2a84dfbefc92925a56050e2bb726d694dea51fb3

I will automatically update this comment whenever this PR is modified

Binder :point_left: Launch a binder notebook on this branch for commit 2feaf5d71b4b07a040cb8bc2c0bce98605fe5e9f

Binder :point_left: Launch a binder notebook on this branch for commit 65cfdaca88456cce50cbf9478cbd91303343c770

Binder :point_left: Launch a binder notebook on this branch for commit 558c2c4f8828f321f73d43017064b82e8e279390

Binder :point_left: Launch a binder notebook on this branch for commit f4b9413d0d9f81500a454a44824ae1399fd0f91a

Binder :point_left: Launch a binder notebook on this branch for commit 8010274364199ebc1bcaad8b3ab18d9150b2245a

Binder :point_left: Launch a binder notebook on this branch for commit 61f5fcd0cb81d1205f0746401bd80f0174a47ae2

Binder :point_left: Launch a binder notebook on this branch for commit d4bc85f07e78812154bb4441394cca450e659410

Binder :point_left: Launch a binder notebook on this branch for commit ba7b4f3849231faaa98c0da9a5e20be69e3725ad

Binder :point_left: Launch a binder notebook on this branch for commit a813fa4b733ae5b16045d8e082aab77bfcd65475

Binder :point_left: Launch a binder notebook on this branch for commit a326c8d78786fd8ae08ffc47a92d3b66d6aba033

Binder :point_left: Launch a binder notebook on this branch for commit 538729badb5cebee926e6b2a6d4fa5f1f5e7ced1

github-actions[bot] avatar Mar 06 '22 03:03 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 66.22%. Comparing base (b2dbb14) to head (538729b).

Files Patch % Lines
icepyx/tests/test_behind_NSIDC_API_login.py 0.00% 6 Missing :warning:
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #289      +/-   ##
===============================================
+ Coverage        66.19%   66.22%   +0.02%     
===============================================
  Files               36       36              
  Lines             3065     3064       -1     
  Branches           541      540       -1     
===============================================
  Hits              2029     2029              
+ Misses             945      944       -1     
  Partials            91       91              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Mar 06 '22 03:03 codecov-commenter

Looks like the issue with adding this test is now #286.

JessicaS11 avatar Mar 07 '22 17:03 JessicaS11

Ok, but I might as well add some unit tests for ATL14 since I've been playing with it recently. Will see what I can do to increase code coverage.

weiji14 avatar Mar 07 '22 17:03 weiji14

Ok, but I might as well add some unit tests for ATL14 since I've been playing with it recently. Will see what I can do to increase code coverage.

Sounds great (and wasn't suggesting we not add the tests already here). Just noticed that now that #288 is resolved with updated certificates at NSIDC, the failing Travis errors were "updated" to #286.

JessicaS11 avatar Mar 07 '22 17:03 JessicaS11

See #291

JessicaS11 avatar Mar 08 '22 02:03 JessicaS11

Hi @rwegener2, could you give this a review if you have time, since you recently worked on the #435 PR?

weiji14 avatar Aug 31 '23 00:08 weiji14

@rwegener2, could you give this a review if you have time

Absolutely, @weiji14. I've been offline for a day or two while moving apartments, but I'll take a look this afternoon.

rwegener2 avatar Sep 01 '23 13:09 rwegener2