icerpc-csharp icon indicating copy to clipboard operation
icerpc-csharp copied to clipboard

Rename `DisableBuildTelemetry` to `IceRpcBuildTelemetry`

Open ReeceHumphreys opened this issue 1 year ago • 2 comments

I would simplify and just use IceRpcBuildTelemetry. If you look at boolean properties here: https://learn.microsoft.com/en-us/visualstudio/msbuild/common-msbuild-project-properties?view=vs-2022, most of them don't have a Disable prefix.

Also, IceRpcBuildTelemetry makes it clearer what it's about.

Originally posted by @bernardnormier in https://github.com/icerpc/icerpc-csharp/pull/4006#discussion_r1664208085


Opening an issue for further discussion on this as there does not seem to be a consensus on if it should be renamed.

ReeceHumphreys avatar Jul 05 '24 17:07 ReeceHumphreys

@InsertCreativityHere's response:

Personally, I prefer the current name. Having it be a 'negative' phrase It makes it very clear that this is opt-out, and that by default, we're sending build telemetry.

Whereas naming it something positive (IMO) implicitly makes it seem more like it's opt-in. At least without having to go read some defaults somewhere.

You are completely correct that most don't have negative prefixes, but it's also not completely taboo, since there are 2 which start with negative prefixes.

ReeceHumphreys avatar Jul 05 '24 17:07 ReeceHumphreys

It could also be BuildTelemetry if it's clear from the context it applies to IceRPC.

bernardnormier avatar Jul 08 '24 19:07 bernardnormier