search-light icon indicating copy to clipboard operation
search-light copied to clipboard

not working in gnome 48

Open paolocalosso opened this issue 10 months ago • 10 comments

today i got gnome48 beta on my debian sid but search light extensions is not working although in metadata file i added "48"

paolocalosso avatar Mar 05 '25 21:03 paolocalosso

fwiw this is the error I get after adding 48 to the metadata.json: TypeError: (intermediate value).enable_unredirect_for_display is not a function

ogarai avatar Mar 22 '25 18:03 ogarai

After making the following change as per the porting guide it starts to work somewhat, but not quite, e.g. the search light shows up using the keyboard shortcut but it doesn't close when hitting excepe. Also, it doesn't open again unless the gnome overview is entered and exited again.

diff --git a/extension.js b/extension.js
index d25c83a..de8d96a 100644
--- a/extension.js
+++ b/extension.js
@@ -450,7 +450,7 @@ export default class SearchLightExt extends Extension {
     this._updateCss();
     this._layout();
 
-    Meta.disable_unredirect_for_display(global.display);
+    global.compositor.disable_unredirect();
 
     this.mainContainer.show();
     this.container.show();
@@ -504,14 +504,14 @@ export default class SearchLightExt extends Extension {
         onComplete: () => {
           this._visible = false;
           this.mainContainer.hide();
-          Meta.enable_unredirect_for_display(global.display);
+          global.compositor.enable_unredirect();
         },
       });
     } else {
       this.mainContainer.opacity = 0;
       this._visible = false;
       this.mainContainer.hide();
-      Meta.enable_unredirect_for_display(global.display);
+      global.compositor.enable_unredirect();
     }
     // this._hidePopups();
   }

ogarai avatar Mar 22 '25 18:03 ogarai

Arch released packages for Gnome 48 today. Search Light doesn't work anymore. Please update this nice extension.

cschult avatar Mar 23 '25 08:03 cschult

Also waiting for an update, arch has already moved to Gnome 48, Fedora is close as well, an update would be great

Belsedar avatar Mar 23 '25 13:03 Belsedar

Same. I miss the extension already. The default fullscreen search menu is really unpleasant to use for me

creeper82 avatar Mar 25 '25 15:03 creeper82

Yeah, having the exact same issue! I really miss the extension!

Hope this updates soon.

rahhing avatar Mar 26 '25 20:03 rahhing

Hi guys, i've made some changes in here please help to validate whether its fix the issue or not

cryptbrn avatar Mar 29 '25 13:03 cryptbrn

Hi guys, i've made some changes in here please help to validate whether its fix the issue or not

Just tried it out seems to work well. Good job! Thanks!

ogarai avatar Mar 29 '25 17:03 ogarai

Hi guys, i've made some changes in here please help to validate whether its fix the issue or not

Works amazingly on CachyOS GNOME 48, thank you!

rahhing avatar Apr 01 '25 10:04 rahhing

+1 to this problem!

aadlanethefrench avatar Apr 05 '25 20:04 aadlanethefrench

Duplicate of #116

Just follow my instructions, folks

https://github.com/icedman/search-light/pull/116#issuecomment-2833915150

brunos3d avatar Apr 28 '25 04:04 brunos3d

Nice! Just waiting the release on GNOME Extensions website. Thanks!

mhalano avatar Jun 06 '25 09:06 mhalano