iced icon indicating copy to clipboard operation
iced copied to clipboard

Rehighlight TextEditor when Theme changes

Open pml68 opened this issue 10 months ago • 5 comments

It's far from perfect, but it's something. Maybe it's even acceptable.

pml68 avatar Feb 25 '25 22:02 pml68

A better solution to this could be checking whether the theme has changed in the draw function, something like this: https://github.com/generic-daw/generic-daw/blob/d2d1c5f95733cd0169ffe03346491cfb959b9049/generic_daw_gui/src/widget/knob.rs#L205-L213

edwloef avatar Feb 27 '25 13:02 edwloef

I tried doing something like that, but adding PartialEq as a trait requirement to the Theme generic caused issues with the Widget trait, but I'll try again today. Maybe I just didn't read the error carefully.

pml68 avatar Feb 27 '25 13:02 pml68

@edwloef I'm not sure what I did wrong last night, but it worked just fine this time around. Thanks for making me try again!

pml68 avatar Feb 27 '25 14:02 pml68

This solves #2817

pml68 avatar Feb 27 '25 14:02 pml68

Would be awesome if this got merged - really helpful 👍

acidjazz avatar Apr 14 '25 06:04 acidjazz