pisa icon indicating copy to clipboard operation
pisa copied to clipboard

Injected parameter scan fails when parameter's nominal value is not in scan range and `reset_free` is set to `True`

Open thehrh opened this issue 6 years ago • 1 comments

As far as I can tell the reason is that the modification of the hypo parameter's ranges does not check whether the new ranges are smaller than the original ones: https://github.com/jllanfranchi/pisa/blob/dev/pisa/scripts/inj_param_scan.py#L201

I don't really see a justification for the script to reduce ranges at all. Unless I'm overlooking something I'm going to fix this.

thehrh avatar Mar 04 '18 13:03 thehrh

It was always meant to just extend the ranges when it needed to. You're right that I didn't actually check if it was reducing the range and to account for that.

steven-j-wren avatar Mar 04 '18 15:03 steven-j-wren

Script was deleted by https://github.com/icecube/pisa/commit/8aaa3060f2374615d9921d264fda0568d5842334.

thehrh avatar Jul 31 '24 07:07 thehrh