Kuba Birecki

I implemented a per-key 'ripple' effect to see how that could be done and proceeded to make a few improvements to the previous code: - Replaced `animation_prep_next_frame` with optional `animation_on_before_frame`...

Thanks again for the review! To answer your questions: >I'm not sure I understand how this works. animations contains a list of animations, but then pixels has each pixel point...

Thanks! Appreciate your input! I'll give the tree/full-px-buffer approach and see how it comes out or if I any serious blocker would pop up. An animation graph seems like it...

>This seems reasonable, but I have one concern with this approach: say you have a keyboard with 100 LEDs, you used two 8x8 matrix drivers to cover them. Would you...

I just pushed some stuff I had already done before our last conversation - including a 'compose' animation with a few blending modes. Attaching a quick demonstration of a setup...

For a start, [I updated my configuration](https://github.com/muriworks/zmk-config/blob/dev/animation-config/config/boards/arm/muri_one/muri_one.dts#L78) taking into account what we talked about. Please take a look when you have a minute @joelspadin, to make sure I didn't miss...

>I hadn't even considered using blending modes. Are there particular effects where that would be useful? Yeah, I do agree it's a bit of a gimmick but I see two...

I updated the API to run just a single call per animation and managed to preserve all of the functionality so I'm happy with that. Regarding the blending modes, I...

I did some exploring on the frame scheduling so we're not running at a constant 30 FPS and I opted to go with a `zmk_animation_request_frames()` function, where any animation can...

>I think I'll need to take a look at the code and see how an animation implemented this way vs. using a ref count compares before I could say which...