jimgui icon indicating copy to clipboard operation
jimgui copied to clipboard

Exposing protected methods in JImGuiGen

Open Mr00Anderson opened this issue 5 years ago • 2 comments

I would like to expose JImGuiGen methods that are private / protected which take native parameter. After a bit of work and work around/efficiencies and nothing really great in terms of generics issues between a String or JImStr, just would be easier to store it as its original intended API type byte[].

This would open up your API easier to anyone to extend it without making PRs as well.

Edit: With this opening up the classes with a long pointer too to enable usage of those with API that has a byte[] but also takes a pointer/long. With getters, or direct access.

Mr00Anderson avatar Jul 10 '19 19:07 Mr00Anderson

How about exposing a JImStr::new(byte[] bla)?

ice1000 avatar Jul 11 '19 05:07 ice1000

The APIs are protected only because I wanted to use them in the JImGui class, otherwise they should be private. I'm recommending JImStr::new(byte[] bla) since it's not much different from exposing the byte[] API.

ice1000 avatar Jul 12 '19 09:07 ice1000