ice_cube icon indicating copy to clipboard operation
ice_cube copied to clipboard

Remove & replace iCal support with dependency on icalendar gem

Open avit opened this issue 8 years ago • 2 comments

Our implementation of iCal parsing is untested and lacking features. There exists a solid maintained icalendar gem that could support conversion to/from .ics format for us.

IceCube is useful for generating the occurrence times from defined schedules, so these two gems could work well together and allow each to focus on its strengths.

This dependency could be optional.

If anyone has experience with the icalendar gem, I'd like to hear your thoughts on this proposal.

avit avatar Mar 19 '17 23:03 avit

Big fan of this proposal - much more flexible and less error-prone since this isn't a big part of IceCube's functionality

seejohnrun avatar Mar 20 '17 00:03 seejohnrun

The parsing I supply to the icalendar gem is very basic but never had any major issues with parsing or generating ics with it. I have however experienced some timezone problems but I don't recall if that was just some tests or some few errors in production. But given https://github.com/icalendar/icalendar/issues/167 it doesn't seem like the parsing is that solid at the moment.

Also note that https://github.com/icalendar/icalendar-recurrence actually uses IceCube for icalendar parsing.

espen avatar Mar 28 '17 17:03 espen