mojoAL icon indicating copy to clipboard operation
mojoAL copied to clipboard

Versioned release

Open absolutelynothinghere opened this issue 2 years ago • 3 comments

Hello, is it possible to create a versioned release for mojoAL? Fixed releases are more convenient for developers than a constantly changing git repo. Thank you.

absolutelynothinghere avatar Jan 01 '24 13:01 absolutelynothinghere

Generally I've been avoiding this, but it's probably a good idea.

I guess we'll call the latest in the sdl2 branch 2.0.0 or something (with a 2.0.1 and 2.0.2 maybe coming at some point for small, obvious fixes), and the sdl3 branch will shortly become 3.0.0.

icculus avatar May 30 '25 20:05 icculus

While this indeed adds an API version, which is great, the ABI version is still missing. Please consider adding something like:

diff -up a/CMakeLists.txt b/CMakeLists.txt
--- a/CMakeLists.txt 2025-05-27 19:44:21.000000000 +0200
+++ b/CMakeLists.txt 2025-07-20 16:27:33.794050997 +0200
@@ -7,6 +7,8 @@ project(mojoAL)
 find_package(SDL3 REQUIRED)

 add_library(mojoal SHARED mojoal.c)
+set_property(TARGET mojoal PROPERTY VERSION 3.0.0)
+set_property(TARGET mojoal PROPERTY SOVERSION 3)
 target_include_directories(mojoal PRIVATE AL)
 target_link_libraries(mojoal SDL3::SDL3)

install() targets are also missing.

rathann avatar Jul 20 '25 20:07 rathann

So the ABI hasn't ever changed (it's the OpenAL 1.1 specification, you can use this library on binaries built 25+ years ago and it'll work), so I'm hesitant to put a MojoAL-specific SOVERSION on this without a good reason.

icculus avatar Jul 21 '25 03:07 icculus