Ryan C. Gordon
Ryan C. Gordon
I think we were just trying to find a point to stop adding features, but this _would_ be useful and (probably) not difficult.
I managed to get CMake 3.14 to work. ``` CMAKE_C_COMPILER_ID: SunPro ``` Also, `if(SOLARIS)` works, too.
The correct fix, fwiw, is to disable Vulkan if libxcb isn't available, but no one should spend time writing autoconf tests at this point, so I'm just disabling Vulkan for...
> I also don't understand why our Xlib-based code requires libxcb for Vulkan Turns out (in SDL3 at least, if not SDL2) we favor Xlib, but if the Vulkan implementation...
> The xcb.h include is commented out in both [SDL2](https://github.com/libsdl-org/SDL/blob/3e4bb5acd019ecdbf6d4a0ef74a6af1e77e24516/src/video/x11/SDL_x11vulkan.c#L31) and [SDL3](https://github.com/libsdl-org/SDL/blob/a4f962fd46b5b0b4ed9d5eb1e40a203cc0e5f422/src/video/x11/SDL_x11vulkan.c#L32). That one is commented out, but vulkan.h includes it, if VK_USE_PLATFORM_XCB_KHR is defined, which SDL_vulkan_internal.h does.
(But again, there isn't even a hypothetical world where Solaris 10--last official update was in 2013--is getting a Vulkan implementation, so it doesn't really matter if it _compiles_ there. :)...
I couldn't coerce CMake itself to build from source, and the prebuilt package of it I dug up fails to load at all...but this isn't my area of expertise, there's...
Yeah, @madebr, go ahead and push the above patch and close this one.
Probably us keeping @madebr busy every waking moment. I have no reason to believe it isn't a correct fix though!
Counter-point: SDL2 is going into maintenance mode, sdl2-config is completely gone in SDL3, Solaris is a quirky niche platform, and we generate this script at build time anyhow...so @madebr's patch...