SDL_sound icon indicating copy to clipboard operation
SDL_sound copied to clipboard

Release tarball is named `SDL_sound`, not `SDL2_sound`

Open sezero opened this issue 3 years ago • 9 comments

@icculus: The release tarball extracts as SDL_sound-2.0.1 and not as SDL2_sound-2.0.1: is this an oversight?

sezero avatar Mar 27 '22 14:03 sezero

The "SDL2_sound" name creeped into some parts of the source, like the CMake file, and I think we named the binary SDL2_sound.so to match other SDL libraries, but the project is still called SDL_sound.

icculus avatar Mar 27 '22 14:03 icculus

It doesn't match the other SDL2 projects, though.

sezero avatar Mar 27 '22 15:03 sezero

Oh, I thought we changed the others.

We should definitely fix that and call it 2.0.2 right away. :/

icculus avatar Mar 28 '22 00:03 icculus

We should definitely fix that and call it 2.0.2 right away. :/

Yep. Although, I don't know how to do the trick with github's release machinery. Another job for you :/

sezero avatar Mar 28 '22 01:03 sezero

Okay, wait, I've definitely got "libSDL2_ttf", "libSDL2_image", and "libSDL2_mixer" libraries in my /usr/local/lib, so this is at least the intended name on Unix systems.

icculus avatar Mar 28 '22 02:03 icculus

Oh, you mean the tarball filename doesn't match other SDL_* libraries. Hmm, let me see how to change that on GitHub's release thing.

icculus avatar Mar 28 '22 02:03 icculus

I don't think I can rename it; this works on SDL_mixer and such because we're just hosting the tarballs at libsdl.org and can name them whatever we want (the GitHub version there is "SDL_mixer-release-2.0.4.tar.gz" !!! ), but GitHub just puts the repository name in front of the tag name here.

icculus avatar Mar 28 '22 03:03 icculus

Maybe we can specifically upload a proper source tarball with the releases like some other projects do - see harfbuzz or libsamplerate for example.

sezero avatar Mar 28 '22 03:03 sezero

You can create a source release with git using:

git archive v2.0.1 -o SDL2_sound-2.0.1.tar.gz --prefix "SDL2_sound-2.0.1/"

sign that archive with your gpg key, and add it to https://github.com/icculus/SDL_sound/releases/tag/v2.0.1

madebr avatar Oct 13 '22 10:10 madebr

Yeah, it'd be great if you could consider doing that for future, as they're guaranteed to return stable results, unlike github commit-based tarballs.

thesamesam avatar Nov 12 '22 02:11 thesamesam

Hey, if a new release was made with the changes in main and with the mentioned fix here, it would be really great.

ericoporto avatar Mar 05 '23 02:03 ericoporto

I think I did this right, with a manually archived tarball and GPG signature: https://github.com/icculus/SDL_sound/releases/tag/v2.0.2

Please let me know if I screwed this up and I'll try again. :)

icculus avatar Jun 29 '23 15:06 icculus