Ian Baker

Results 409 comments of Ian Baker

> Maybe we should ask Ktor lib to expose a way to get the OkHttpEngine/OkHttpClient instead ? This seems like a a reasonable request to me. ---- Regarding the suggestion...

Since you came here from https://github.com/google/ExoPlayer/issues/11229, i just want to check: are you using a custom `DataSource` implementation similar to that issue? If so, my suggestion is the same as...

Something isn't right in your screenshot. I would expect to see all the tests defined in `DataSourceContractTest` being run, like when I run [`FileDataSourceContractTest`](https://github.com/androidx/media/blob/main/libraries/datasource/src/test/java/androidx/media3/datasource/FileDataSourceContractTest.java): In your screenshot it seems that...

You may also want to take a look at https://github.com/androidx/media/issues/856. From your original comment you mention: > I use encrypt with “AES/CBC/PKCS5Padding” Since you are using CBC then you likely...

I'm going to close this because I think the original questions have been answered, and additional high-touch support on the details of implementing a `DataSource` correctly are beyond the capacity...

> This may be caused by this commit > [30cb762](https://github.com/androidx/media/commit/30cb76269a67e09f6e1662ea9ead6aac70667028) That commit shouldn't affect Android 15 (`SDK_INT == 35`), because all the logic is gated by a `SDK_INT == 34`...

Thank for you for confirming. Are you able to explain your repro set-up in more detail? You mention 'shared element transitions' - is that referring to this Compose feature? https://developer.android.com/develop/ui/compose/animation/shared-elements...

@onlymash I'm afraid investigating this further is blocked on us reproducing the issue. I'm not sure when I'll have the time to build a repro example from scratch (especially since...

Thank you, I can reproduce a difference in behaviour when toggling the media3 dependency in your project between 1.3.0 and 1.4.0. I have passed this on to the graphics team...

I've changed the Compose workaround to be opt-in, which should fix the issue reported here - thanks for reporting. This change should be included in 1.5.0-beta01.