Ian Baker

Results 409 comments of Ian Baker

Closing all PRs on this deprecated project. We are now unable to merge PRs from here. If you would like us to consider this change again please file a new...

@Abu-Abdullah Have you also overridden `isCommandAvailable`? See this note on extending `ForwardingPlayer` consistently: https://developer.android.com/guide/topics/media/exoplayer/customization#intercepting_method_calls_with_forwardingplayer

It's possible I'm misunderstanding, but wouldn't you use key rotation to allow more easily revoking access to content (by denying the next key request, and then playback is forced to...

I think sending a PR with what you've got so far makes sense. **Heads up:** We have some work planned that will change how subtitle data flows from muxed formats...

I'm going to mark this as low priority to indicate that we (exoplayer-team) have no immediate plans to directly work on implementing this - but we will of course prioritise...

I can reproduce the problem. When handling concurrent subtitles, we currently assume each one is only one line high (the `-i` below): https://github.com/google/ExoPlayer/blob/f72ca8338399c9e3c19e73fc0779f24baff14d35/library/extractor/src/main/java/com/google/android/exoplayer2/text/webvtt/WebvttSubtitle.java#L81-L88 Unfortunately that logic is executing when we're...

Changing ExoPlayer's rendering logic is quite involved and we don't have plans to look at this soon. If we 'fix' the WebVTT logic to precisely match the spec without changing...

The conclusion(s) I came to when I last looked into this: 1. The WebVTT spec provides some clear defaults for lots of properties if they're not set. 2. ExoPlayer currently...

@AnonymousWebHacker > Actually, what happens is that many devices do not have support for HEVC (except for 10bit) at the hardware level, so to play the videos, you need a...

Closing all PRs on this deprecated project. We are now unable to merge PRs from here. If you would like us to consider this change again please file a new...