django-icekit icon indicating copy to clipboard operation
django-icekit copied to clipboard

Make publication datetimes actually cause the page to be published/unpublished, rather than just modifying the queryset

Open cogat opened this issue 9 years ago • 2 comments

At the moment, the behaviour is that the editor must publish the content, which can then only be viewed between the given dates.

Desired behaviour is that the editor can leave a prior version published, set the start or end publish dates on an updated draft item, and when the time arrives, the prior published version is updated with the scheduled version. Also people who follow content will want a notification at scheduled publication time, not at 'save' time.

So rather than moderating the queryset to exclude items outside of the window, instead schedule the publication/unpublication action using celery.

NB must be tolerant to celery restarts, and changes of mind.

cogat avatar Nov 03 '16 01:11 cogat

It looks like the publishing schedule controls aren't in icekit-events; possibly not anything other than Pages.

I think the fields should be part of PublishingModel; they're fairly intrinsic/inextricable to the publishing mechanism, even if doing so increases the complexity of that model. Thoughts @jmurty ?

cogat avatar Mar 15 '17 21:03 cogat

At present the scheduled publishing controls come from Fluent Pages' UrlNode class, or thereabouts, that is used as a basis for pages. None of the other non-page models have similar fields yet.

It's worth pointing out that the scheduled publishing feature provided by Fluent Pages' is not yet compatible with ICEkit's publishing mechanism with draft & published copies. So there is no advantage in using what Fluent Pages' provides, in particular, versus adding our own similar (or maybe even quite different) scheduling fields to the publishing package.

jmurty avatar Mar 15 '17 22:03 jmurty