ng-iScroll icon indicating copy to clipboard operation
ng-iScroll copied to clipboard

Doesn't work with iScroll5

Open whitneyland opened this issue 12 years ago • 9 comments

I think the changes may be minor.

I know iScroll5 is still beta, but he claims it will be released any day now, so it'd be great to get support in your nice directive.

whitneyland avatar Jun 11 '13 22:06 whitneyland

I have pushed a new branch v1.2b that enables use of iScroll 5.0. See: https://github.com/ibspoof/ng-iScroll/tree/v1.2b

Once iScroll 5 is officially released I will make the 1.2b code be the default release.

ibspoof avatar Jun 11 '13 22:06 ibspoof

very cool, thanks-

whitneyland avatar Jun 11 '13 22:06 whitneyland

For 1.2b, should the default options be changed to match the default options in iScroll5?

From the example, it looks like the defaults are var ngiScroll_opts = { mouseWheel: true };

whitneyland avatar Jun 12 '13 15:06 whitneyland

I updated the options to include the "mouseWheel: true" option as part of the default settings. If any other options are wanted to be added or changed the $scope.$parent.myScrollOptions can be used to add or override in your Controller.

ibspoof avatar Jun 13 '13 16:06 ibspoof

When I add this directive with the latest iScroll version, I get the "iScroll is not defined" error message. Shouldn't this be "new IScroll(element[0], ngiScroll_opts);" (capital i) instead of "new iScroll(element[0], ngiScroll_opts);"?

        // iScroll initialize function
        function setScroll()
        {
            if (scope.$parent.myScroll === undefined) {
                scope.$parent.myScroll = [];
            }

            scope.$parent.myScroll[scroll_key] = new iScroll(element[0], ngiScroll_opts);
        }

Thanks.

emiyake avatar Aug 19 '13 19:08 emiyake

Now iScroll 5.1 is out and Angularjs is 1.2.. please update. Thanks

numediaweb avatar Feb 16 '14 23:02 numediaweb

Any updates on this? Now that we have a newer iScroll & Angular?

stvhanna avatar May 19 '14 16:05 stvhanna

Is there a fix for this issue? Is anyone using with ng-infinite-scroll 1.0?

rowens72 avatar Dec 09 '14 05:12 rowens72

iscroll5 works fine on Chrome but the ng-iscroll v1.2 doesn't work

demo.htm it is still referencing v4 src='http://rawgithub.com/cubiq/iscroll/v4/src/iscroll.js

I referenced v5 and then I changed line 82 of ng-scroll.js from scope.$parent.myScroll[scroll_key] = new iScroll(element[0], ngiScroll_opts); to scope.$parent.myScroll[scroll_key] = new IScroll(element[0], ngiScroll_opts);

(Capital I in IScroll) Then it works

RezaRahmati avatar Jan 30 '15 14:01 RezaRahmati