ng-iScroll icon indicating copy to clipboard operation
ng-iScroll copied to clipboard

capitalize "i" in IScroll

Open benjamingeorge opened this issue 11 years ago • 6 comments

On line 82 you have 'new iScroll' which resulted in an undefined error. To get this to work in my angular project I needed a capital " I " such as "new IScroll() "

benjamingeorge avatar Dec 04 '13 21:12 benjamingeorge

@benjamingeorge you're using the wrong file, the capitilized "i" is for iscroll5, if you are using iscroll5 then you must use 1.2b ng-iscroll.js...as readme says:

"AngularJS Module that enables iScroll 4.x to work using a directive. If you are looking for a iScroll 5 compatible version please checkout the ng-iScoll 1.2b branch"

diegolameira avatar Dec 05 '13 02:12 diegolameira

Yeah I saw that. I installed via Bower and since the 1.2 branch of iscroll is the only one with a bower.json I assumed installing it with bower would pull the that branch. Is this not the case? Do I have to download the zip?

On Dec 4, 2013, at 8:25 PM, Diego Lameira [email protected] wrote:

@benjamingeorge you're using the wrong file, the capitilized "i" is for iscroll5, if you are using iscroll5 then you must use the 1.2b ng-iscroll.js...as readme says:

"AngularJS Module that enables iScroll 4.x to work using a directive. If you are looking for a iScroll 5 compatible version please checkout the ng-iScoll 1.2b branch"

— Reply to this email directly or view it on GitHub.

benjamingeorge avatar Dec 05 '13 02:12 benjamingeorge

Look, you can get sources in bower from specific branches... If you run "bower help install" you'll get something like this:

Endpoints...

  • # Where:
  • is a package URL, physical location or registry name
  • is a valid range, commit, branch, etc.

With that in mind, you can run "bower install ng-iScroll#v1.2b --save-dev"

So, no need to download it manually.

diegolameira avatar Dec 05 '13 03:12 diegolameira

thank you.

On Dec 4, 2013, at 9:14 PM, Diego Lameira [email protected] wrote:

Look, you can get sources in bower from specific branches... If you run "bower help install" you'll get something like this:

Endpoints...

#

Where:

is a package URL, physical location or registry name is a valid range, commit, branch, etc. With that in mind, you can run "bower install ng-iScroll#v1.2b --save-dev"

So, no need to download it manually.

— Reply to this email directly or view it on GitHub.

benjamingeorge avatar Dec 05 '13 03:12 benjamingeorge

Thank you @diegolameira ! This small line (how to install a specific branch) saved me lots of time. Thank you!

neoswf avatar Mar 31 '14 20:03 neoswf

This helped me as well. It might be worthwhile to stick a comment in the readme about getting the v1.2b branch for Bower noobs like me.

racingcow avatar May 06 '14 19:05 racingcow