astra icon indicating copy to clipboard operation
astra copied to clipboard

Hyper 1.0

Open ibraheemdev opened this issue 2 years ago • 3 comments

Upgrade to Hyper 1.0, look into what extra features we can implement now (timers, etc.).

ibraheemdev avatar Nov 19 '23 23:11 ibraheemdev

Hello,

Thanks for your work on this project!

Do you still have time to work on astra and do you plan to upgrade to the latest Hyper version someday?

libvoid avatar Sep 25 '24 16:09 libvoid

Hi, I'm a little crunched for time at the moment. I do plan to upgrade to Hyper 1.0 at some point, unfortunately I can't give you a concrete timeline. Also happy to review and accept a PR :)

ibraheemdev avatar Sep 25 '24 22:09 ibraheemdev

I'd be happy to help, but my quick try made me realize that I might not be skilled enough for this task. There is a lot of breaking changes :/

My attempt was to replace the old hyper::Body struct which is now a trait by this:

type BoxBody = http_body_util::combinators::BoxBody<Bytes, Infallible>;
pub struct Body(pub BoxBody);

But I'm not sure about this and I didn't succeed to correctly implement the Iterator trait to this new type

Happy to hear this project isn't abandoned anyway :)

libvoid avatar Sep 26 '24 13:09 libvoid

Oooh! That's nice! Thank you @ibraheemdev! :)

libvoid avatar Nov 08 '24 10:11 libvoid

Hey, I just noticed there's a new release. Just wanted to leave some voice of support and appreciation.

dpc avatar Nov 22 '24 17:11 dpc