openshift-letsencrypt icon indicating copy to clipboard operation
openshift-letsencrypt copied to clipboard

Published 20 hours ago • verified publisher icon ibotty

Clusterrole updated

Open macmacs opened this issue 8 years ago • 5 comments

I added the clusterrole.yaml from openshift-acme.

It fixes #26.

macmacs avatar Sep 16 '17 11:09 macmacs

We don't need as many permissions. Can you test without endpoints, services, events, and most important: secrets?

ibotty avatar Sep 17 '17 05:09 ibotty

Removed endpoints, services, events and secrets.

Works!

macmacs avatar Sep 17 '17 08:09 macmacs

Looks good. Do you have a 1.5 cluster handy to test, whether the cluster role also works there? I could only test some time next week.

Also, I prefer if you could rebase the changes to one logical change, I.e. group the Readme changes and the cluster role change. Thank you!

ibotty avatar Sep 17 '17 13:09 ibotty

At the moment, I don't have a 1.5 cluster at hand. Sorry.

And I will look into rebasing soon.

macmacs avatar Sep 25 '17 13:09 macmacs

Don't worry, I will test later that week.

ibotty avatar Sep 25 '17 14:09 ibotty